Add beta-cyfluthrin as target for cyfluthrin - #165
Merged
Conversation
ecoinvent do that in their mapping
Collaborator
|
Hi @fchichorro thanks for digging into all of these. One minor request: we try to maintain the flowables and contexts separately, so in most of the cases you've submitted, you can simply add one line to the flowables mapping file (e.g. ReCiPe2016FlowableMappings.csv), and then run the script build_lcia_mapping.py (note you'll need to change the target LCIA method in line 14). This may not work for #164, which will require a different approach. |
Contributor
Author
|
Hi @bl-young, thank you for the feedback. I had indeed not noticed those functions, I will surely use them for any subsequent commit. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ecoinvent maps recipe cyfluthrin to beta-cyfluthrin. We could do the same, i.e., to use cyfluthrin as a proxy for beta-cyfluthrin? The advantage to that is that ecoinvent processes with beta-cyfluthrin get impacts for this elementary flow. I used the recipe cyfluthrin to fedefl cyfluthrin as a template to create the new flow mappings. @ErCollao @ganorris.