Skip to content

Fix images in changelog not loading - #7202

Open
BlackYps wants to merge 6 commits into
developfrom
fix-changelog
Open

Fix images in changelog not loading#7202
BlackYps wants to merge 6 commits into
developfrom
fix-changelog

Conversation

@BlackYps

@BlackYps BlackYps commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description of the proposed changes

The unit icons for the balance changelog had a broken url, so they didn't load. See: https://faforever.github.io/fa/changelog/fafdevelop
While fixing this I also improved the documentation a little.

Testing done on the proposed changes

In the local environment the images still work, so hopefully they will now also work once we deploy the changes.

Additional context

@lL1l1 can you convert the rest of the balance snippets to the new format? I started doing it, but then I realized there is more important stuff that I should attend to and if I do it then other people don't learn to use the new format.
There are also non-balance snippets that still have the PR number at the start. Could you change these also? Most of them are yours anyway. You can just make a PR with all the changed snippets, then I will review it quickly.

Summary by CodeRabbit

  • Balance Updates

    • Reduced the Loyalist T3 Siege Assault Bot’s stun duration against T1/T2 mobile units.
    • Adjusted Novax orbital laser lifetime, radius, aiming speed, charge costs, energy drain, base-station costs, and build time.
    • Replaced Novax Omni detection with sonar.
  • Bug Fixes

    • Fixed missing unit icons on the changelog website.
  • Features

    • Updated documentation for the quick load hotkey and enhanced chat window functionality, including scaling, commands, autocomplete, clipboard copying, and message ordering.

@BlackYps BlackYps changed the title Fix changelog Fix images in changelog not loading Aug 4, 2026
@BlackYps
BlackYps requested a review from lL1l1 August 4, 2026 19:57
@github-actions
github-actions Bot marked this pull request as draft August 4, 2026 19:57
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The PR updates changelog snippet formatting, adds unit-scoped balance examples, changes unit icon paths to relative paths, expands regex documentation, and revises several feature and fix entries.

Changes

Changelog formatting

Layer / File(s) Summary
Snippet format and rendering
docs/development-changelog/balance-snippet.md, docs/_plugins/*.rb
The balance snippet template now uses Blueprint IDs and unit-scoped titles. The documentation adds a Novax Center example. Unit icons use relative asset paths.
Balance snippet migration
changelog/snippets/balance.7121.md, changelog/snippets/balance.7123.md
The Loyalist and Novax balance entries now use unit-tagged blocks.
Changelog entry updates
changelog/snippets/features.7066.md, changelog/snippets/features.7098.md, changelog/snippets/other.7202.md
The quick load and chat-window entries were reformatted. A unit-icon loading fix entry was added.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: area: documentation, area: tooling

Suggested reviewers: ll1l1, rhaelya

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'Fix images in changelog not loading' directly addresses the main change: fixing a broken URL that prevented unit icons from displaying in the balance changelog.
Description check ✅ Passed The description covers the proposed changes, testing performed, and additional context. However, the requested checklist items are not confirmed, and no link to issue #7202 is present despite the PR fixing it.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-changelog

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BlackYps
BlackYps marked this pull request as ready for review August 4, 2026 20:02

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/_plugins/balance_change.rb`:
- Line 17: Update the comment near the balance-list regex in balance_change.rb
to reference unit_block.rb as the implementation responsible for rendering the
unit icon and title, replacing the incorrect self-reference while leaving the
surrounding behavior unchanged.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dcacb297-9d7e-4370-8214-6566bde23500

📥 Commits

Reviewing files that changed from the base of the PR and between 658b338 and 4b36ba3.

📒 Files selected for processing (8)
  • changelog/snippets/balance.7121.md
  • changelog/snippets/balance.7123.md
  • changelog/snippets/features.7066.md
  • changelog/snippets/features.7098.md
  • changelog/snippets/other.7202.md
  • docs/_plugins/balance_change.rb
  • docs/_plugins/unit_block.rb
  • docs/development-changelog/balance-snippet.md

# ending with a colon in the first line and having an arrow (-> in html) in
# the second. This is specific enough to not accidentally catch normal text or
# itemized lists.
# The unit icon and title is handled by balance_change.rb.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Point the comment to the correct plugin.

docs/_plugins/balance_change.rb applies the balance-list regex. docs/_plugins/unit_block.rb renders the unit icon and title. Update Line 17 so it references unit_block.rb; the current text directs maintainers to the wrong implementation.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/_plugins/balance_change.rb` at line 17, Update the comment near the
balance-list regex in balance_change.rb to reference unit_block.rb as the
implementation responsible for rendering the unit icon and title, replacing the
incorrect self-reference while leaving the surrounding behavior unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants