Skip to content

Fix Salem's wobble due to alt and main footprint size difference - #7200

Merged
lL1l1 merged 2 commits into
FAForever:developfrom
4z0t:fix/SalemWobble
Aug 3, 2026
Merged

Fix Salem's wobble due to alt and main footprint size difference#7200
lL1l1 merged 2 commits into
FAForever:developfrom
4z0t:fix/SalemWobble

Conversation

@4z0t

@4z0t 4z0t commented Aug 3, 2026

Copy link
Copy Markdown
Member
I found that the main and alt footprints not matching in size is the issue. This makes sense because footprints are used for pathfinding structures according to `footprints.lua`, and if you switch pathfinding structs then I guess it just breaks.
To test this change we need to see in `footprints.lua` what footprints are available. We're interested in "WaterLand" and "Water" footprint types. Currently salem is trying to define its footprints in the bp as 2x8 for both main and alt, which when conforming to footprints.lua makes a main 5x5 (waterland) and alt 4x4 (water) (idk why the engine chooses these). If we change the bp definitions to 3x3 for both then the issue stops happening. If footprints.lua adds a 5x5 water footprint it also stops.

(c) Nomander

We decided to changed 5x5 water|land to 4x4 since there is no unit that uses that footprint (there are only engineers that use water|land from what we see)

Summary by CodeRabbit

  • Bug Fixes
    • Fixed Salem movement lockups when handling many move orders by reducing its floating footprint from 5×5 to 4×4.
    • Large floating or hover-based mod units may be affected by this footprint adjustment.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9cf7fe69-7b68-465f-b37c-a6d6ee41d15a

📥 Commits

Reviewing files that changed from the base of the PR and between 9440940 and 08e67bb.

📒 Files selected for processing (1)
  • changelog/snippets/fix.7200.md

📝 Walkthrough

Walkthrough

The WaterLand5x5 footprint declaration was replaced with WaterLand4x4. Its dimensions changed from 5x5 to 4x4. Other movement and terrain constraints remain unchanged. The changelog records the adjustment and its possible effect on mod units.

Changes

WaterLand footprint

Layer / File(s) Summary
Update WaterLand footprint dimensions
lua/footprints.lua, changelog/snippets/fix.7200.md
The footprint name and dimensions change from WaterLand5x5 and 5x5 to WaterLand4x4 and 4x4. Movement capabilities, depth limits, slope, and flags remain unchanged. The changelog documents the adjustment and its possible effect on mod units.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the Salem wobble and its footprint-size cause, which matches the main change.
Description check ✅ Passed The description explains the footprint mismatch, the selected fix, and the expected behavior, but it does not provide concrete test results or complete the checklist.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lL1l1 lL1l1 added type: bug area: sim Area that is affected by the Simulation of the Game area: unit-blueprint related to issues in unit blueprints (*_unit.bp) labels Aug 3, 2026
@lL1l1 lL1l1 changed the title Fix Salem's wobble when toggle for land|water mode is enabled Fix Salem's wobble due to alt and main footprint size difference Aug 3, 2026
@4z0t

4z0t commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

Before the fix:

2026-08-03_21-17-54.mp4

After the fix:

aaahwobbling.mp4

@lL1l1
lL1l1 merged commit 658b338 into FAForever:develop Aug 3, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: sim Area that is affected by the Simulation of the Game area: unit-blueprint related to issues in unit blueprints (*_unit.bp) type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants