Repository navigation
test(gl): do not build the GL bridge test on Windows - #954
Merged
Merged
Conversation
video_input_bridge_gl_test needs a GL context. The Windows CI runner has
no OpenGL driver GStreamer can use ("No GL shader support available"),
so with STROM_REQUIRE_GST_PLUGINS set the test failed and turned the
Windows build on main red since #949. PR CI skips Windows, so #949 never
saw it. Linux CI keeps running the test, with surfaceless EGL.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Windows build on
mainhas been red since #949.video_input_bridge_gl_testneeds a GL context, and the Windows CI runner cannot create one (No GL shader support available). WithSTROM_REQUIRE_GST_PLUGINSset, that turned into a test failure. PR CI skips Windows unless theci:windowslabel is set, so #949 never ran this test there.The test is now not built on Windows (
#![cfg(not(target_os = "windows"))]), and its header says why. Linux CI keeps running it with surfaceless EGL, so it still guards the bridge.Type of Change
Testing
cargo test --test video_input_bridge_gl_teston macOS: passed.ci:windowslabel on this PR.🤖 Generated with Claude Code