Repository navigation
test(vision mixer): the tally guard checks lag, not lead - #1018
Merged
Merged
Conversation
tally_follows_a_cut_on_the_same_frame_with_late_inputs asserted |lag| <= 2 frames. On the macOS runner the tally switched 10 frames *before* the picture (tally at 0.400 s, picture at 0.733 s): the picture switch itself arrived late on the slow runner. That is not the bug the test guards (the tally trailing the picture by the input delay, 5-6 frames with do-timestamp), so only bound the lag. Locally it also measured exactly 2.0 frames once, which float noise pushed over the bound; use < 3.5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tally_follows_a_cut_on_the_same_frame_with_late_inputs(#1009) asserted|lag| <= 2frames. In the first macOS run with--no-fail-fast(#1016) it was the only failing test:late inputs: picture switched at 0:00:00.733333333, tally at 0:00:00.400000000: tally lag -10.0 frame(s). The tally switched before the picture because the picture switch itself arrived late on the slow runner. Locally it also measured exactly 2.0 frames once, which float noise pushed over the bound.Change
Bound only the lag (the bug is the tally trailing the picture by the input delay, 5–6 frames with do-timestamp) and use
< 3.5frames. Test-only.Evidence
< 3.5.Tests
Ran (macOS, GStreamer 1.28.6):
vision_mixer_overlay_upload_test2× (3 passed). This PR carriesci:macos.🤖 Generated with Claude Code