chore: remove unused AWS Terraform configuration - #285
Merged
Conversation
The infra/terraform/aws configuration describes infrastructure that is no longer in use — nothing from it is deployed on AWS anymore. Removing the dead configuration also removes a security group definition that opened MongoDB and SSH to 0.0.0.0/0 and ::/0 on a public instance, which is a pattern that should not be copied into new setups. The readme section documenting the removed Terraform workflow is dropped with it. The Open Source Cloud deploy path (infra/terraform/eyevinn-osc and the OSC Terraform examples) is unaffected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
birme
approved these changes
Aug 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
infra/terraform/aws/(main.tf,.terraform.lock.hcl) and the## Terraform infrastructuresection ofreadme.mdthat documented how to run it.Why
This configuration describes infrastructure that is no longer in use — nothing from it is deployed on AWS anymore. Jonas Birmé (VP R&D) confirmed on 2026-07-23 that none of it is used any longer and approved removing it.
Beyond being dead code, the security group in
main.tfopened the MongoDB port and SSH to0.0.0.0/0and::/0on an instance with a public IP. Nothing is running from this config, so this is not a live exposure — but it is a pattern that should not be copied into any new setup, and it has already caused a review to reach the wrong conclusion about our current footprint.Scope / not affected
infra/terraform/eyevinn-osc/and the OSC Terraform examples referenced from the readme remain as-is.aws/ecs/taskdef-*.jsontask definitions and the ECR/ECS steps in.github/workflows/development.ymlare a separate deploy path and are deliberately left alone in this PR.Reference checks performed
Searched the repository for anything pointing at the removed directory — CI workflows,
package.jsonscripts, docs/readme, and Terraform resource names:readme.md## Terraform infrastructure(cd infra+terraform plan/apply -var-file=...)### Contributingpromoted to##since it was nested under the removed section.github/workflows/development.yml→aws/ecs/taskdef-dev.json, ECR/ECS deploy stepsinfra/terraform/eyevinn-osc/README.md.gitignore→.terraform/package.jsonscriptsNo workflow, script, or Makefile invokes the removed directory.
Verification
npm ci— cleannpm run lint— 0 errors (278 pre-existing warnings, unchanged)npm run typecheck/npm run pretty— clean, no diff producednpm test— 241/243 pass. The 2 failures are insrc/api_re_auth.test.ts/src/api_share.test.tsand pass when run in isolation (pre-existing flakiness under the full parallel run). This PR touches no application code.