Skip to content

Route pending action aliases through Agents API #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 2 commits into from
May 23, 2026
Merged

Route pending action aliases through Agents API #2196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
082c820
fix: route pending action aliases through Agents API
chubes4 May 22, 2026
6771513
test: cover canonical pending action alias shape
chubes4 May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 37 additions & 3 deletions inc/Engine/AI/Actions/PendingActionInspectionAbility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,19 @@ function () {
* Ability callback: list actions.
*/
public static function list_actions( array $input ): array {
$result = \AgentsAPI\AI\Approvals\agents_list_pending_actions(
array( 'filters' => self::normalize_filters( $input ) )
);
if ( is_wp_error( $result ) ) {
return array(
'success' => false,
'error' => $result->get_error_message(),
);
}

return array(
'success' => true,
'actions' => PendingActionStore::list( self::normalize_filters( $input ) ),
'actions' => is_array( $result['actions'] ?? null ) ? $result['actions'] : array(),
);
}

Expand All @@ -152,7 +162,21 @@ public static function get_action( array $input ): array {
);
}

$action = PendingActionStore::inspect( $action_id );
$result = \AgentsAPI\AI\Approvals\agents_get_pending_action(
array(
'action_id' => $action_id,
'include_resolved' => true,
)
);
if ( is_wp_error( $result ) ) {
return array(
'success' => false,
'error' => $result->get_error_message(),
'action_id' => $action_id,
);
}

$action = is_array( $result['action'] ?? null ) ? $result['action'] : null;
if ( null === $action ) {
return array(
'success' => false,
Expand All @@ -171,9 +195,19 @@ public static function get_action( array $input ): array {
* Ability callback: summarize actions.
*/
public static function summary( array $input ): array {
$result = \AgentsAPI\AI\Approvals\agents_summary_pending_actions(
array( 'filters' => self::normalize_filters( $input ) )
);
if ( is_wp_error( $result ) ) {
return array(
'success' => false,
'error' => $result->get_error_message(),
);
}

return array(
'success' => true,
'summary' => PendingActionStore::summary( self::normalize_filters( $input ) ),
'summary' => is_array( $result ) ? $result : array(),
);
}

Expand Down
69 changes: 69 additions & 0 deletions tests/pending-actions-agents-api-contract-smoke.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ function datamachine_pending_actions_source( string $path ): string {
foreach ( array( 'datamachine/list-pending-actions', 'datamachine/get-pending-action', 'datamachine/summarize-pending-actions' ) as $ability ) {
datamachine_pending_actions_assert( str_contains( $inspection_source, $ability ), $ability . ' ability is registered', $failures, $passes );
}
foreach ( array( 'agents_list_pending_actions', 'agents_get_pending_action', 'agents_summary_pending_actions' ) as $canonical_callback ) {
datamachine_pending_actions_assert( str_contains( $inspection_source, $canonical_callback ), 'Data Machine pending-action alias delegates to Agents API ' . $canonical_callback, $failures, $passes );
}
foreach ( array( '/actions', '/actions/(?P<action_id>', '/actions/summary' ) as $route ) {
datamachine_pending_actions_assert( str_contains( $inspection_source, $route ), $route . ' REST route is registered', $failures, $passes );
}
Expand Down Expand Up @@ -177,8 +180,42 @@ function delete_transient( string $key ): bool {
}
}

if ( ! function_exists( 'sanitize_text_field' ) ) {
function sanitize_text_field( $value ) {
return trim( strip_tags( (string) $value ) );
}
}

if ( ! function_exists( 'is_wp_error' ) ) {
function is_wp_error( $value ): bool {
return $value instanceof WP_Error;
}
}

if ( ! class_exists( 'WP_Error' ) ) {
class WP_Error {
private string $message;

public function __construct( string $_code = '', string $message = '' ) {
$this->message = $message;
}

public function get_error_message(): string {
return $this->message;
}
}
}

if ( ! function_exists( 'apply_filters' ) ) {
function apply_filters( string $_hook_name, $value ) {
if ( 'wp_agent_pending_action_store' === $_hook_name && isset( $GLOBALS['datamachine_pending_action_store_override'] ) ) {
return $GLOBALS['datamachine_pending_action_store_override'];
}

if ( 'wp_agent_pending_action_store' === $_hook_name && class_exists( '\DataMachine\Engine\AI\Actions\PendingActionStore' ) ) {
return \DataMachine\Engine\AI\Actions\PendingActionStore::adapter();
}

return $value;
}
}
Expand Down Expand Up @@ -211,6 +248,7 @@ function wp_generate_uuid4(): string {
require_once dirname( __DIR__ ) . '/inc/Engine/AI/Actions/WordPressActionDispatchObserver.php';
require_once dirname( __DIR__ ) . '/inc/Engine/AI/Actions/PendingActionStoreAdapter.php';
require_once dirname( __DIR__ ) . '/inc/Engine/AI/Actions/PendingActionStore.php';
require_once dirname( __DIR__ ) . '/inc/Engine/AI/Actions/PendingActionInspectionAbility.php';

\DataMachine\Engine\AI\Actions\PendingActionObservers::reset();
\DataMachine\Engine\AI\Actions\PendingActionObservers::register( new \DataMachine\Engine\AI\Actions\WordPressActionDispatchObserver() );
Expand All @@ -232,6 +270,7 @@ function wp_generate_uuid4(): string {
'datamachine' => array(
'created_by' => 123,
'agent_id' => 456,
'context' => array( 'session_id' => 'session_contract_smoke' ),
),
),
)
Expand All @@ -247,6 +286,36 @@ function wp_generate_uuid4(): string {
datamachine_pending_actions_assert( $stored instanceof \AgentsAPI\AI\Approvals\WP_Agent_Pending_Action && $action_id === $stored->get_action_id(), 'contract store preserves action ID in payload', $failures, $passes );
datamachine_pending_actions_assert( $stored instanceof \AgentsAPI\AI\Approvals\WP_Agent_Pending_Action && null !== $stored->get_expires_at(), 'transient fallback preserves expiration audit data', $failures, $passes );

$GLOBALS['datamachine_pending_action_store_override'] = new class( $stored ) implements \AgentsAPI\AI\Approvals\WP_Agent_Pending_Action_Store {
public function __construct( private \AgentsAPI\AI\Approvals\WP_Agent_Pending_Action $action ) {}
public function store( \AgentsAPI\AI\Approvals\WP_Agent_Pending_Action $action ): bool { unset( $action ); return true; }
public function get( string $action_id, bool $include_resolved = false ): ?\AgentsAPI\AI\Approvals\WP_Agent_Pending_Action { unset( $include_resolved ); return $action_id === $this->action->get_action_id() ? $this->action : null; }
public function list( array $filters = array() ): array { unset( $filters ); return array( $this->action ); }
public function summary( array $filters = array() ): array { unset( $filters ); return array( 'total' => 1 ); }
public function record_resolution( string $action_id, \AgentsAPI\AI\Approvals\WP_Agent_Approval_Decision $decision, string $resolver, $result = null, ?string $error = null, array $metadata = array() ): bool { unset( $action_id, $decision, $resolver, $result, $error, $metadata ); return true; }
public function expire( ?string $before = null ): int { unset( $before ); return 0; }
public function delete( string $action_id ): bool { unset( $action_id ); return true; }
};

$alias_list = \DataMachine\Engine\AI\Actions\PendingActionInspectionAbility::list_actions( array( 'kind' => 'contract_smoke' ) );
$alias_list_action = $alias_list['actions'][0] ?? array();
datamachine_pending_actions_assert( true === ( $alias_list['success'] ?? false ), 'Data Machine list alias succeeds through Agents API store contract', $failures, $passes );
datamachine_pending_actions_assert( isset( $alias_list_action['preview'] ) && array( 'ok' => true ) === $alias_list_action['preview'], 'Data Machine list alias returns canonical preview field', $failures, $passes );
datamachine_pending_actions_assert( 'agent:456' === ( $alias_list_action['agent'] ?? null ), 'Data Machine list alias returns canonical agent field', $failures, $passes );
datamachine_pending_actions_assert( 'user:123' === ( $alias_list_action['creator'] ?? null ), 'Data Machine list alias returns canonical creator field', $failures, $passes );
datamachine_pending_actions_assert( 'session_contract_smoke' === ( $alias_list_action['metadata']['datamachine']['context']['session_id'] ?? null ), 'Data Machine list alias keeps Data Machine context in canonical metadata', $failures, $passes );
datamachine_pending_actions_assert( isset( $alias_list_action['created_at'] ) && is_string( $alias_list_action['created_at'] ), 'Data Machine list alias returns canonical created_at field', $failures, $passes );
datamachine_pending_actions_assert( ! array_key_exists( 'preview_data', $alias_list_action ), 'Data Machine list alias no longer exposes legacy preview_data field', $failures, $passes );

$alias_get = \DataMachine\Engine\AI\Actions\PendingActionInspectionAbility::get_action( array( 'action_id' => $action_id ) );
datamachine_pending_actions_assert( true === ( $alias_get['success'] ?? false ), 'Data Machine get alias succeeds through Agents API store contract', $failures, $passes );
datamachine_pending_actions_assert( isset( $alias_get['action']['preview'] ) && array( 'ok' => true ) === $alias_get['action']['preview'], 'Data Machine get alias returns canonical preview field', $failures, $passes );
datamachine_pending_actions_assert( 'agent:456' === ( $alias_get['action']['agent'] ?? null ), 'Data Machine get alias returns canonical agent field', $failures, $passes );
datamachine_pending_actions_assert( 'user:123' === ( $alias_get['action']['creator'] ?? null ), 'Data Machine get alias returns canonical creator field', $failures, $passes );
datamachine_pending_actions_assert( 'session_contract_smoke' === ( $alias_get['action']['metadata']['datamachine']['context']['session_id'] ?? null ), 'Data Machine get alias keeps Data Machine context in canonical metadata', $failures, $passes );
datamachine_pending_actions_assert( isset( $alias_get['action']['expires_at'] ) && is_string( $alias_get['action']['expires_at'] ), 'Data Machine get alias returns canonical expires_at field', $failures, $passes );
datamachine_pending_actions_assert( ! array_key_exists( 'preview_data', $alias_get['action'] ), 'Data Machine get alias no longer exposes legacy preview_data field', $failures, $passes );

$legacy_action_id = 'act_legacy_smoke';
$product_payload = array(
'action_id' => $legacy_action_id,
Expand Down
Loading