InvalidNetworkError should not extend Error - #69
Merged
Merged
Conversation
MegaManSec
force-pushed
the
pr/jr-2-b7da262
branch
from
February 16, 2026 18:52
e304613 to
84f1d14
Compare
(cherry picked from commit b7da262d6e21cef1ff295ff41ae558754e79e4f1)
MegaManSec
force-pushed
the
pr/jr-2-b7da262
branch
from
February 16, 2026 18:56
84f1d14 to
9e152fa
Compare
JakubKorytko
approved these changes
Sep 29, 2026
JakubKorytko
left a comment
JakubKorytko
left a comment
Member
There was a problem hiding this comment.
Tested on Android emulator (release build, RN 0.81). With an unsupported network, main crashes on the old architecture (FATAL EXCEPTION: mqt_native_modules, InvalidNetworkError) and rejects with Exception in HostFunction: ... on the New Architecture. With this PR both reject cleanly with the error message. LGTM.
Member
|
closed for a moment to fix ci check, lgtm, thank you! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.