Runtime guard for invalid buttonType indexing (prevents crash + norma… - #66
Merged
Merged
Conversation
MegaManSec
force-pushed
the
pr/jr-12-79d2399
branch
from
February 16, 2026 18:52
b0a3779 to
354829e
Compare
…lizes prop) (cherry picked from commit 79d23999de7ac1a3863e881737dc746829d14e97)
MegaManSec
force-pushed
the
pr/jr-12-79d2399
branch
from
February 16, 2026 18:56
354829e to
c5d39e4
Compare
JakubKorytko
approved these changes
Sep 29, 2026
JakubKorytko
left a comment
JakubKorytko
left a comment
Member
There was a problem hiding this comment.
Tested on Android emulator and iOS simulator (release builds, RN 0.81). With buttonType="foo", main throws TypeError: Cannot convert undefined value to object during render; with this PR it falls back to the basic button on both platforms. Valid basic/badge render pixel-identical to main. LGTM.
Member
|
closing for a moment to fix ci check, lgtm |
Member
|
thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lizes prop)