Allow overriding document options via options prop#54
Merged
mountiny merged 2 commits intoJun 26, 2026
Merged
Conversation
1 task
FitseTLT
approved these changes
Jun 25, 2026
FitseTLT
left a comment
FitseTLT
left a comment
There was a problem hiding this comment.
I assume exposing the whole option prop is ok even if we only made a change to the cmapurl.
LGTM
Contributor
52 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
optionsprop (typed asDocumentProps['options']) that defaults toDEFAULT_DOCUMENT_OPTIONSand is forwarded to<Document>. This way, this prop can be overridden by consimer.DEFAULT_DOCUMENT_OPTIONS.cMapUrlto/cmaps/. Reason explained here: [PDF Viewer] Black text disappears from certain PDF receipts after they finish rendering (web) App#94484 (comment)Related Issues
Expensify/App#94484
Manual Tests
N/A
Linked PRs
Expensify/App#94568