Fix dependent tag second-level row stuck faded after selecting first-level tag by MelvinBot · Pull Request #94756 · Expensify/App

MelvinBot · 2026-06-27T03:36:29Z

Explanation of Change

When a dependent (multi-level) tag's first level is selected, the newly-revealed second-level tag row (e.g. Region after selecting State) appeared empty/faded on iOS and Android until the user tapped it.

Root cause: MenuItemWithTopDescription applied the entry-fade animation style only while its highlighted prop was true (outerWrapperStyle={highlighted ? highlightedOuterWrapperStyle : outerWrapperStyle}). For a freshly-revealed dependent tag row, highlighted flips true → false on the very next render — mid-animation — which detaches the animated highlight style from the native node before the fade's withTiming completes. The shared value keeps animating to 1 on the UI thread, but nothing reads it anymore, so the row freezes at a partial opacity. Web was unaffected because it re-applies the flattened style on every React commit.

Fix: Extracted the highlight into a dedicated HighlightableMenuItemWithTopDescription that owns the useAnimatedHighlightStyle hook and always applies the animated style (no longer gated on highlighted), so the style stays attached for the entire fade. When highlighted is false, the hook returns a static opacity: 1 with no pulse (initialNonRepeatableProgressValue = 1), so the always-applied style is inert for non-highlighted rows. MenuItemWithTopDescription is reverted to a plain pass-through, leaving a single highlight implementation.

Migrated the three remaining MenuItemWithTopDescription call sites that pass highlighted:

MoneyRequestConfirmationList/sections/TagFields.tsx (the reported bug)
pages/iou/SplitExpenseEditPage.tsx (same dependent-tag pattern)
ReportActionItem/MoneyRequestView.tsx

The WorkspaceInitialPage/DomainInitialPage call sites already use the separate HighlightableMenuItem component (which already applies its highlight style unconditionally), so they needed no change.

Fixed Issues

$ #94005
PROPOSAL: #94005 (comment)

Tests

Create a workspace and enable Tags in More features.
Open Tags → Import → Multi-level tags → Choose file → upload dependent tags → toggle off "Are these independent tags".
Tap Next → Import → Got it.
Start creating a manual expense in the workspace and enter an amount.
On the confirmation page, open the first-level tag row (e.g. State) and select a value (e.g. California).
Back on the Confirm details page, verify the second-level tag row (e.g. Region) is fully visible (not empty/faded) without needing to tap it.
Verify the same on iOS App and Android App.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios
- I turned off my network connection and tested it while offline
- I tested this PR with a High Traffic account against the staging or production API
I verified the PR is properly formatted

videos

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

…hlight style Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>

codecov · 2026-06-27T03:39:54Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MenuItemWithTopDescription.tsx	`100.00% <100.00%> (ø)`
...c/components/ReportActionItem/MoneyRequestView.tsx	`73.28% <ø> (ø)`
src/pages/iou/SplitExpenseEditPage.tsx	`0.00% <ø> (ø)`
...oneyRequestConfirmationList/sections/TagFields.tsx	`0.00% <0.00%> (ø)`
...onents/HighlightableMenuItemWithTopDescription.tsx	`0.00% <0.00%> (ø)`
... and 19 files with indirect coverage changes

bernhardoj · 2026-06-28T13:03:07Z

+            // The animated highlight style is always applied (never swapped on `highlighted`) so the entry fade is never
+            // detached from the node mid-animation. When `highlighted` is false the hook returns a static opacity: 1, so
+            // this is inert for non-highlighted rows. See https://github.com/Expensify/App/issues/94005.
+            outerWrapperStyle={[outerWrapperStyle, animatedHighlightStyle]}


@MelvinBot No need for a comment here and instead of rendering a MenuItem, let's render MenuItemWithTopDescription here.

Done in 7f5ec07. Now renders MenuItemWithTopDescription (which already sets shouldShowBasicTitle/shouldShowDescriptionOnTop) and removed the comment.

bernhardoj · 2026-06-28T14:20:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>

bernhardoj · 2026-06-28T15:52:19Z

@MelvinBot i've done testing and everything looks good. Please complete the author checklist and mark this PR as ready

melvin-bot · 2026-06-28T15:55:38Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

carlosmiceli · 2026-06-28T16:09:56Z

@bernhardoj I think Melvin swallowed some checlist items

bernhardoj · 2026-06-28T16:15:02Z

@MelvinBot remove the Screenshot/Videos section and replace the PR Author Checklist with below checklist

checklist

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

bernhardoj · 2026-06-28T16:22:13Z

@MelvinBot remove the unchecked checklist. It's not part of the checklist.

bernhardoj · 2026-06-28T16:26:28Z

@MelvinBot replace the Screenshot/Videos section with below

videos

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

Fix dependent tag second-level row stuck faded by always applying hig…

5db1cbb

…hlight style Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>

MelvinBot assigned bernhardoj Jun 27, 2026

MelvinBot requested a review from a team June 27, 2026 03:36

bernhardoj reviewed Jun 28, 2026

View reviewed changes

Render MenuItemWithTopDescription and drop redundant comment

7f5ec07

Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>

MelvinBot marked this pull request as ready for review June 28, 2026 15:55

MelvinBot requested a review from a team as a code owner June 28, 2026 15:55

melvin-bot Bot requested review from bernhardoj and flaviadefaria June 28, 2026 15:55

melvin-bot Bot removed request for a team and flaviadefaria June 28, 2026 15:55

bernhardoj approved these changes Jun 28, 2026

View reviewed changes

melvin-bot Bot requested a review from carlosmiceli June 28, 2026 15:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix dependent tag second-level row stuck faded after selecting first-level tag#94756

Fix dependent tag second-level row stuck faded after selecting first-level tag#94756
MelvinBot wants to merge 2 commits into
mainfrom
claude-dependentTagRowEmptyHighlight

MelvinBot commented Jun 27, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jun 27, 2026 •

edited by github-actions Bot

Loading

Uh oh!

bernhardoj Jun 28, 2026

Uh oh!

bernhardoj Jun 28, 2026

Uh oh!

MelvinBot Jun 28, 2026

Uh oh!

bernhardoj commented Jun 28, 2026

Uh oh!

bernhardoj commented Jun 28, 2026

Uh oh!

melvin-bot Bot commented Jun 28, 2026

Uh oh!

carlosmiceli commented Jun 28, 2026

Uh oh!

bernhardoj commented Jun 28, 2026

PR Author Checklist

Uh oh!

bernhardoj commented Jun 28, 2026

Uh oh!

bernhardoj commented Jun 28, 2026

Screenshots/Videos

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

MelvinBot commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bernhardoj Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Jun 28, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

bernhardoj commented Jun 28, 2026

Uh oh!

melvin-bot Bot commented Jun 28, 2026

Uh oh!

carlosmiceli commented Jun 28, 2026

Uh oh!

bernhardoj commented Jun 28, 2026

PR Author Checklist

Uh oh!

bernhardoj commented Jun 28, 2026

Uh oh!

bernhardoj commented Jun 28, 2026

Screenshots/Videos

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MelvinBot commented Jun 27, 2026 •

edited

Loading

codecov Bot commented Jun 27, 2026 •

edited by github-actions Bot

Loading