[No QA]: refactor: move participant setters from IOU/index.ts to MoneyRequest.ts#90299
Open
DylanDylann wants to merge 2 commits into
Open
[No QA]: refactor: move participant setters from IOU/index.ts to MoneyRequest.ts#90299DylanDylann wants to merge 2 commits into
DylanDylann wants to merge 2 commits into
Conversation
…st.ts Moves 6 participant-related functions out of IOU/index.ts into the co-located MoneyRequest.ts module: - setMoneyRequestParticipants - getMoneyRequestParticipantsFromReport - setMoneyRequestParticipantsFromReport - setMultipleMoneyRequestParticipantsFromReport - getIOURequestPolicyID - updateLastLocationPermissionPrompt Follows PR Expensify#90157 (init/start move). No re-exports — external callers updated directly. DAG stays clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
4d4f890 to
9b877a0
Compare
Contributor
|
No product review needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Part of #72804 — break up the oversized
src/libs/actions/IOU/index.ts.Follow-up to #90157 (init/start move). This PR moves 6 participant-related functions
from
src/libs/actions/IOU/index.tstosrc/libs/actions/IOU/MoneyRequest.ts:setMoneyRequestParticipantsgetMoneyRequestParticipantsFromReportsetMoneyRequestParticipantsFromReportsetMultipleMoneyRequestParticipantsFromReportgetIOURequestPolicyIDupdateLastLocationPermissionPromptMoneyRequest.tswas already importing 5 of the 6 functions fromindex.ts— movingthem in completes the co-location.
Byte-identical move except for namespace→named import renames:
OnyxTypes.Report→ReportOnyxTypes.Transaction→TransactionNo re-exports in
index.ts— external callers updated directly to import from@userActions/IOU/MoneyRequest. DAG stays clean.This is PR G2a of the
index.tscleanup series:requestMoneyfromTrackExpense.tsFixed Issues
$ #72804
PROPOSAL: N/A — code-organization refactor.
Tests
Offline tests
N/A — purely a code-organization refactor; runtime behavior is identical.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A — refactor only, no UI changes.