Conversation
Every Glue database this module creates has a trailing slash baked into location_uri. When a downstream Iceberg client creates a table without an explicit LOCATION, it concatenates this database location with "/" + tableName. Some client versions/code paths (Iceberg's HiveCatalog pre-1.11.0, Spark's own default-location resolution - see apache/iceberg#15908, still open) don't strip a trailing slash before doing that concatenation, producing s3://bucket//table instead of s3://bucket/table. This has produced 1,586+ affected tables across data-dw, data-test, and data-corp, owned by 50+ different applications. Fixing each producing application's Iceberg/Spark version individually doesn't scale across that many independent producers. Removing the trailing slash here removes the material every one of those code paths needs to produce a double slash, regardless of which application or library version is creating the table. This is a location_uri-only change (in-place Glue API update, not a resource replacement) and only affects the default location computed for new tables created without an explicit LOCATION going forward. It does not touch any existing table's location or data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Glue database this module creates has a trailing slash baked into location_uri. When a downstream Iceberg client creates a table without an explicit LOCATION, it concatenates this database location with "/" + tableName. Some client versions/code paths (Iceberg's HiveCatalog pre-1.11.0, Spark's own default-location resolution - see apache/iceberg#15908, still open) don't strip a trailing slash before doing that concatenation, producing s3://bucket//table instead of s3://bucket/table.
This has produced 1,586+ affected tables across data-dw, data-test, and data-corp, owned by 50+ different applications. Fixing each producing application's Iceberg/Spark version individually doesn't scale across that many independent producers. Removing the trailing slash here removes the material every one of those code paths needs to produce a double slash, regardless of which application or library version is creating the table.
This is a location_uri-only change (in-place Glue API update, not a resource replacement) and only affects the default location computed for new tables created without an explicit LOCATION going forward. It does not touch any existing table's location or data.
📝 Description
🔗 Related Issues