fix(core): build and export revocation-view as a real package entry - #76
Merged
Conversation
createRevocationView (added alongside the RevocationCheck implementation) was never added to tsdown's entry list, so it built into no dist output at all and package.json's exports map (regenerated from that same entry list) never carried a ./domain/revocation-view subpath. Every in-repo test imported the source file directly and never noticed; agent-comms, a real external consumer, could not import it at all.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createRevocationView (added in #66 alongside the RevocationCheck implementation) was never added to tsdown's entry list, so it built into no dist output at all and package.json's exports map (regenerated from that same entry list, per tsdown's exports: true config) never carried a ./domain/revocation-view subpath.
Every in-repo test imported the source file directly (../src/domain/revocation-view.js) and never noticed. agent-comms, a real external consumer depending on the published wire-mesh-core package, could not import it at all -- found while wiring RevocationView into agent-comms' own P3.2 token-verification work.