fix(release): drop the plugins that commit a version bump back to main - #74
Merged
Conversation
This repo's own branch protection requires every change to main go through a pull request with Required Checks passing -- a policy the GITHUB_TOKEN identity semantic-release runs as has no bypass for, unlike a repo owner's personal account. @semantic-release/git's direct push of a version-bump commit is therefore permanently rejected here, confirmed on the first push that got this far: "GH013: Repository rule violations... Changes must be made through a pull request." Dropping @semantic-release/git (and @semantic-release/changelog, which existed only to feed it a CHANGELOG.md entry) leaves npm publish, the GitHub Release, and the git tag all still working -- none of those write to the main branch ref, only the tag ref, which this repo's ruleset does not restrict. The tag, the GitHub Release, and the npm registry are the release's source of truth for its version; the repository's own package.json is not expected to reflect it.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo's own branch ruleset ("main required checks") enforces a pull_request rule -- every change to main must go through a PR with the Required Checks status passing -- and its bypass_actors only grant the RepositoryRole bypass (a repo owner's personal account bypasses it, the GITHUB_TOKEN identity semantic-release runs as does not). @semantic-release/git's direct commit+push of a version bump is therefore permanently rejected here.
Confirmed on the first push that got this far (34656198871), after the writer-version fix: analyzeCommits and generateNotes both completed successfully this time, then @semantic-release/git's push failed outright with "GH013: Repository rule violations... Changes must be made through a pull request."
Dropping @semantic-release/git (and @semantic-release/changelog, which only existed to feed it a CHANGELOG.md entry) leaves npm publish, the GitHub Release, and the git tag all still working -- none of those write to the main branch ref, only the tag ref, which the ruleset's own conditions (refs/heads/main only) don't restrict. The tag, GitHub Release, and npm registry are the release's source of truth for version; this repo's own package.json isn't expected to track it, matching the repo's existing deliberate choice to keep main PR-only rather than loosening that policy to accommodate a bot push.