fix(release): add the conventionalcommits preset's own parser package - #72
Merged
Merged
Conversation
release.config.ts configures conventional-commits presets for both commit-analyzer and release-notes-generator, but neither @semantic-release/commit-analyzer nor conventional-commits-parser bundles the actual preset package -- it's loaded dynamically by name at runtime and must be installed alongside. Confirmed on the first real push where release-core actually ran (rather than being skipped or failing before reaching this step): analyzeCommits failed outright with Cannot find module 'conventional-changelog-conventionalcommits'.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.config.ts configures the conventionalcommits preset for both commit-analyzer and release-notes-generator, but that preset package (conventional-changelog-conventionalcommits) isn't bundled by either plugin -- it's loaded dynamically by name at runtime and must be installed alongside, exactly why agent-comms' own identical release config already declares it as a devDependency.
Confirmed on the first real push where release-core actually ran (34653837335, after #71's skip-propagation fix): npm's OIDC verifyConditions succeeded (trusted publishing is correctly wired), GitHub auth verified, then analyzeCommits failed outright with "Cannot find module 'conventional-changelog-conventionalcommits'".