Skip to content

fix(ci): stop release-core's skip propagating from its dry-run sibling #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mearman merged 1 commit into from
Sep 11, 2026
Merged

fix(ci): stop release-core's skip propagating from its dry-run sibling #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,8 @@ jobs:

release-core:
name: Release wire-mesh-core
if: github.ref == 'refs/heads/main' && github.event_name == 'push'
# required-checks' own needs include release-core-dry-run, which is deliberately skipped on a push event (it only runs for pull_request) -- GitHub Actions propagates that skip transitively through the needs graph to this job by default even though required-checks itself succeeds, so the condition checks required-checks' own result explicitly rather than relying on implicit success() propagation.
if: ${{ !cancelled() && needs.required-checks.result == 'success' && github.ref == 'refs/heads/main' && github.event_name == 'push' }}
needs: [required-checks]
runs-on: ubuntu-latest
permissions:
Expand Down