fix(ci): point release-core's pnpm/action-setup at ts/package.json - #70
Merged
Conversation
pnpm/action-setup reads the packageManager field from the repo root's package.json by default, but this repo has no root package.json -- the field lives at ts/package.json, exactly the reason ts-verify already passes package_json_file explicitly. Without it, the release job failed outright on every push to main with "No pnpm version is specified", before ever reaching the actual release step.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
… check The release job only ever ran on push to main, so nothing in a PR's own CI exercised it -- the pnpm/action-setup bug this same branch fixes merged three times before anyone noticed main had gone red on every push since. A dry-run job now runs the identical checkout/pnpm-setup/install/build path on every PR and calls semantic-release --dry-run instead of a real publish, wired into required-checks so a break in that shared path fails the PR itself rather than surfacing only after merge.
Member
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Mearman
added a commit
that referenced
this pull request
Sep 11, 2026
release-core-dry-run runs only on pull_request and is deliberately skipped on a push -- but required-checks' own needs list includes it, and GitHub Actions propagates a skipped dependency's status transitively through the needs graph by default, skipping release-core too even though required-checks itself succeeds. Confirmed on the first real push after #70 merged: required-checks reported success, but release-core still skipped outright with zero steps run, so it never even reached the pnpm-setup fix that same PR was meant to ship. Checking needs.required-checks.result explicitly, rather than relying on the implicit success() check, evaluates only this job's own direct dependency instead of the whole transitive graph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-core job (added in #65) has failed on every push to main since it landed, before ever reaching semantic-release: pnpm/action-setup reads the packageManager field from the repo root's package.json by default, and this repo has no root package.json -- the field lives at ts/package.json. ts-verify already works around this by passing package_json_file: ts/package.json explicitly; release-core was missing the same fix.
Confirmed root cause from the two failed push-to-main runs so far (both "Error: No pnpm version is specified").