feat: add wire-mesh's device-id derivation to PeerIdentity - #55
Merged
Conversation
wire-mesh's own identity model keys a peer on SHA-256 of its raw public-key bytes, never a certificate's DER encoding — the exact instability this project's own certificate-fingerprint peerId already has (identity-store.ts's own renewal-near-expiry logic mints a fresh fingerprint, and therefore a fresh agent id, well before the underlying key actually changes). Migrating agent-comms onto wire-mesh's transport needs this value available before anything can switch peerId over to it. Purely additive: PeerIdentity.deviceId is derived alongside the existing certificate/fingerprint in both generateIdentity() and the persisted-identity reload path, but nothing reads it yet. MeshStore.peerId still comes from fingerprint. The certificate-building code is unchanged; it continues to wrap the same keypair deviceId is derived from.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #47 (P2: substrate swap). Step 2 of the phase's own sequencing plan -- see the P2 design pass.
wire-mesh's identity model keys a peer on SHA-256 of its raw public-key bytes, never a certificate's DER encoding -- the exact instability this project's own certificate-fingerprint peerId already has (identity-store.ts's own renewal-near-expiry logic mints a fresh fingerprint, and therefore a fresh agent id, well before the underlying key actually changes). Migrating onto wire-mesh's transport needs this value available before anything can cut peerId over to it.
Purely additive: PeerIdentity.deviceId is derived alongside the existing certificate/fingerprint in both generateIdentity() and the persisted-identity reload path, but nothing reads it yet -- MeshStore.peerId still comes from fingerprint, and the existing TlsTransport keeps working entirely unchanged. The certificate-building code is untouched; it continues to wrap the same keypair deviceId is now also derived from.
Test plan