fix(release): retry connection-level and expired-JWT MCP publish failures - #181
Merged
Merged
Conversation
…lures isRetryablePublishFailure only recognised npm-propagation-lag and 5xx failures, so a raw connection timeout (no HTTP status at all) or a 401 caused by the login JWT expiring mid-retry-window failed the release job outright instead of retrying, leaving a git tag with no matching npm package or GitHub release. Add isConnectionError to match Go net-error text (dial tcp, i/o timeout, connection refused, connection reset, no such host) from mcp-publisher's own HTTP client. Add isExpiredJwt to match a 401 whose body specifically says the token is expired, deliberately excluding a 401 from a genuine authorisation failure, which retrying can never fix regardless of how fresh the token is.
mcp-publisher only logged in once, before the retry loop started, so a retry attempt late enough in the 15-minute budget presented a JWT that had since expired. Retrying with the same expired token just 401s again, so the classifier alone can't fix this: run the login step again before every retry attempt, mint a fresh token, and let the next publish attempt use it.
Mearman
marked this pull request as ready for review
September 17, 2026 17:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #180
Two more failure modes of the Release job's MCP-registry publish step weren't recognised as retryable by
isRetryablePublishFailure, so the release failed outright instead of retrying, leaving a git tag with no matching npm package or GitHub release.mcp-publisher login github-oidcruns once before the retry loop starts).isRetryablePublishFailurenow recognises both. For the JWT case,scripts/publish-mcp-registry.tsalso re-runs the login step before every retry attempt (not just the JWT-expiry retries), since retrying with the same expired token would just 401 again and a fresh login before any other retryable failure is harmless.