feat(core): surface the ask tier at the tool layer - #179
Merged
Merged
Conversation
…apability requests Holds an incoming capability-request open exactly as RoomProtocol's own pendingRoomJoins and ConnectionApproval's own pendingInboundConnections already do, surfacing each one as a capability_request event a human can act on. Built directly on wire-mesh-core's createCapabilityRequestHandler (the same ask primitive agent-comms#164's bubble-up module builds on), so accepting a held ask mints and returns the granted token exactly as core/room's own room.join admission does.
…ending actions Adds a capability_request DeliveryEvent variant and capability_pending/ capability_accept/capability_reject CommsAction variants, wires them through MeshStore (constructing a CapabilityAskAdmission and exposing createCapabilityAskHandler as the registration point a capability-gated verb uses) and CommsTool, and registers the new actions in the MCP tool schema and every exhaustive DeliveryEvent switch.
Mearman
force-pushed
the
feat/ask-tier-ux
branch
from
September 17, 2026 17:13
441f172 to
f5fe9d7
Compare
Mearman
marked this pull request as ready for review
September 17, 2026 17:18
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #165
Adds the generic, capability-agnostic admission surface for the ask tier: a capability-request that lands in neither allow (a held token already answers canGrant) nor deny (canGrant says no and resolveBubbleUpRoute finds no route to bubble up to) is held open and surfaced to the owning agent, mirroring the shape RoomProtocol's own pendingRoomJoins/acceptRoomJoin/rejectRoomJoin and ConnectionApproval's own connection_request admission already establish, generalised the way the issue asks for.
CapabilityAskAdmission(src/core/capability-ask.ts), built directly on wire-mesh-core'screateCapabilityRequestHandler.capability_requestdelivery event,capability_pending/capability_accept/capability_rejecttool actions, wired throughMeshStoreandCommsTool.MeshStore.createCapabilityAskHandleris the registration point a capability-gated verb (e.g. agent-comms#162's dm:send) wires into its own session to get a ready manage-request handler backed by this admission's live pending state.More work in progress on this branch.