fix(cross-model): accept Codex CLI effort values none and max - #1567
Open
saurabhkagent-lab wants to merge 3 commits into
Open
fix(cross-model): accept Codex CLI effort values none and max#1567saurabhkagent-lab wants to merge 3 commits into
saurabhkagent-lab wants to merge 3 commits into
Conversation
The effort whitelist was a stale copy of the Codex enum, so pinning cross_model_effort to none or max skipped the peer as incompatible. Keep fail-closed for values the route cannot honor.
GitHub reported CONFLICTING because skills/guides moved; git merged cleanly via rename detection. No conflict resolution required.
Main renamed skills/guides/configuration.md; the allowlist pin must follow so the enum test still covers the shipped docs surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cross_model_effortrejected Codex CLI valuesnoneandmaxeven though those are validmodel_reasoning_effortenums (Codex CLI 0.150.1). Fail-closed is still correct for values the route cannot honor; the whitelist was a stale copy of the provider enum.This PR adds
codex:noneandcodex:maxto both review workers (validate_effort_overridestays byte-identical), updates the comment/docs/config copies of that list, and pins the seven-value enum in tests so the next CLI addition cannot silently drift.Editorial default remains
xhigh.ce-work/ce-povhardcodedhighis unchanged.Validation
bun test tests/skills/ce-code-review-cross-model-routes.test.ts tests/skills/ce-setup-check-health.test.ts— 161 passbun run release:validate— in syncCloses #1565
Security Disclosure
No security-relevant changes.
Agent Disclosure