fix: inherit agent model in Skill Forge LLM calls#208
Open
guix4ever wants to merge 1 commit into
Open
Conversation
guix4ever
marked this pull request as ready for review
July 24, 2026 06:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llm_gate_modelis unsetRoot cause
The context-engine factory did not pass the active agent model into either Skill Forge LLM stage.
QueryRewriterhad no model parameter, whileLLMGateFilterreceivedNonewhen no gate-specific override was configured. Both calls could therefore fall back to a provider-level default that differed fromagents.defaults.model, including models unavailable in the user's region.Impact
The rewriter and gate now use the same configured model as the agent by default. Deployments that set
skillForge.llmGateModelcontinue to use that explicit model for gate calls.Follow-up consideration
A future change could add an optional
rewrite_modeloverride, withagents.defaults.modelas its fallback. That would let operators pin a cheaper or lower-latency model for query rewriting without relying on an implicit provider default. This PR intentionally does not add a new configuration field so the fix remains focused on model inheritance.Validation
uv run pytest tests/test_skill_forge_rewriter.py tests/test_skill_forge_gate.py tests/test_phase_a_default_engine.py -q— 33 passeduv run --extra dev ruff checkon all changed Python filesuv run --extra dev ruff format --checkon all changed Python filesgit diff --checkCloses #155.