fix(agent): keep file search off the gateway event loop#194
Open
louiseboo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FindToolfilesystem traversal and result formatting to a worker threadFindToolan explicit 30-second execution ceilingRoot cause:
FindTool.execute()performed synchronousPath.glob()traversal inside an async method. A slow filesystem walk blocked the gateway event loop, so channel polling and the surroundingasyncio.wait_for()timeout could not run until traversal returned.Type
Verification
uv run pytest tests/test_search_tools.py tests/test_file_search_traversal_guard.py tests/test_tool_registry_timeout.py -q— 29 passedmake test-python— 59 passedmake lint-python— passeduv run pre-commit run --files raven/agent/tools/file_search.py tests/test_search_tools.py— passedA broader local suite attempt reached 4,477 passing tests, with 124 failures and 19 errors in environment-dependent EverOS, Boxlite,
tui-use, and TUI integration tests unavailable on this machine. The focused search, traversal-guard, timeout, lint, and repository CI smoke suites above all pass.Risk and rollback
Privacy
The issue and this PR contain only sanitized technical evidence. No private paths, business files, credentials, chat content, or user identifiers are included.
Fixes #193