Repository navigation
Name both speakers so memories don't quote raw ids - #6
Merged
Merged
Conversation
Extraction labels each speaker by sender_name and falls back to sender_id, so stored memories read "default-user said ..." locally and, on the HTTP server, quote the user's opaque account id. Send "User" / "Assistant". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Extraction labels each speaker by
sender_nameand falls back tosender_id(everalgoboundary/chat.py:speaker = m.sender_name or m.sender_id). We never send a name, so:Both EverOS Cloud (
MessageItem.sender_name) and self-hosted (memorize.py) acceptsender_name.Change
add_memoryandrecord_trajectorysendsender_name="User"/"Assistant"on user and assistant messages (tool messages unchanged).sender_idis untouched, so ownership and isolation are unaffected.Tests
New
test_add_memory_names_both_speakers; the trajectory test now asserts the names. 92 passed.🤖 Generated with Claude Code