fix(ci): merge release build into release-please's own workflow - #5
Merged
Conversation
Tagging via release-please-action's GITHUB_TOKEN doesn't cascade into a new workflow run, so the previous tag-triggered release.yaml never fired (v0.1.0 was released with no attached binaries). Gate the build job on release-please's release_created output instead, in the same workflow, and scope permissions per job rather than at workflow level. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y1zVUQDr4rhZozGUQBgHgH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.yaml(déclenché surpush: tags) n'a jamais tourné : la doc GitHub/release-please-action confirme que GitHub ne redéclenche pas de workflow sur un ref créé via leGITHUB_TOKENd'un workflow en cours.v0.1.0a donc été taguée/publiée sans binaires attachés.release-pleaselui-même : un second jobbuild, gaté sur l'outputrelease_createdderelease-please-action(pattern officiellement documenté pargoogleapis/release-please-action), checkoute le tag produit et lancegoreleaser.buildn'a pluspull-requests: write, qu'il n'utilise pas.release-as: "0.1.0"(recommandation officielle release-please : à retirer une fois la Release PR mergée).Test plan
review-plan→builtin:code-reviewmedium,claudeurs:kilroy,claudeurs:houdini) : 1 finding (permissions non scopées par job) corrigéactionlint🤖 Generated with Claude Code
https://claude.ai/code/session_01Y1zVUQDr4rhZozGUQBgHgH