Repository navigation
Conversation
Plain reset could not load a corrupt config-profiles file, while the UI told users to reset or repair it. Co-authored-by: Cursor <cursoragent@cursor.com>
A deleted profile rebuilt under the same name kept revision 1, so an old snapshot still passed the save check and overwrote the new profile. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A save from an old snapshot can no longer overwrite a profile that was deleted and created again with the same name, or a collection rebuilt by
sbms config reset --all --backup. The save matches the active profile's name, instance id, and revision, and asks the user to reload the configuration when they do not.Identity
sbms config resetkeep the id and increase the revision.Reload the configuration before saving. The tray shows that error and does not retry the stale draft.AppConfigdocuments. An import file that containsinstance_idis rejected. Replacing an existing profile keeps its id.Migration
The store file remains
config-profiles-v1.json. Valid version 1 collections are migrated once, inside the profile lock, to document version 2. The original file stays unchanged if that write fails, and no snapshot is returned until the new ids are read back. A numeric version greater than 2 is left unchanged. SBMS 2.0.2 cannot read version 2 and returns before writing.Validation
cargo fmt --all -- --checkandcargo clippy --all-targets --target x86_64-pc-windows-msvc --locked -- -D warningspassed.cargo testdid not run:link.exeis not installed here.Test plan
cargo teston windows-2022gamingrecreated at revision 1 rejects the old snapshot and keeps the new contentsRelated
Related: #54
This branch is based on #54. Until that PR is in
main, this comparison also contains the damaged-collection recovery commit.