Miscellaneous minor cleanups#747
Merged
Merged
Conversation
philsmt
reviewed
Jun 11, 2026
| # Paths starting with /gpfs/exfel/exp are either the canonical link | ||
| # on Maxwell or an ONC path. | ||
| euxfel_exp_path_pattern = re.compile( | ||
| r'\/gpfs\/exfel\/exp\/(\w+)\/(\d{6})\/p(\d{6})\/([a-z]+)\/(?:r(\d{4})|.extra_data)') |
Contributor
There was a problem hiding this comment.
Are you sure these are not necessary? The site I am regularly using to test regexps claims they are 🤷
Member
Author
There was a problem hiding this comment.
In Javascript and some other languages, / marks regex literals, i.e. const re = /ab+c/;. I'd guess this is what the site is referring to. But Python doesn't have regex literals, and / has no special meaning in Python style regexes. I've just double checked this interactively. re.escape("/") also doesn't add a backslash.
Contributor
There was a problem hiding this comment.
Thanks for the clarification!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernising type hints, removing unused imports and unnecessary character escapes. This cuts down on the warnings I see in Pycharm.
I'll merge this so long as the tests pass, I don't think it's worth review.