Expand support for RUN data#735
Open
philsmt wants to merge 3 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
philsmt
force-pushed
the
feat/flexible-run-data
branch
from
aeece25 to
3246e9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For data reduction purposes, we would like to be able to store trainless metadata accessible via EXtra-data. After some experimentation, the most elegant solution appears to be allowing
REDUCTIONsources (any other type of source) to haveRUNvalues. Assuming there are no source name collisions between the sections, there is indeed no hard requirement in either EXtra-data or the EXDF data format in general on restrictingRUNvalues toCONTROL.This PR therefore relaxes the restriction to
CONTROLsources to instead check for the existance ofRUNdata for the given source. In this respect the API remains backwards-compatible, as the sameValueErroris raised and for legacy code, there is no difference between asking for non-CONTROLdata or any source withoutRUNdata.In addition, it adds some additional convenience methods when working with
RUNdata in the form ofSourceData.run_keys(inc_timestamps=True)KeyData.run_value(allow_multi_run=False)