Remove LPD Mini component class (pending redesign)#418
Merged
Conversation
Contributor
|
Looks like there's some documentation at least in docs/lpd_data.ipynb and docs/aipgd_lpd_data.rst. LGTM otherwise. |
Member
Author
|
Thanks, good catch. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current component is wrong, based on when we thought LPD Mini was a single 256 x 256 pixel detector, and we're still working out some issues with the redesign. We don't want to keep delaying the release for this, so it was suggested that we remove the LPD Mini wrapper for now so we can release other improvements and spend more time on it.
See #381 for the work to add it back.