fix/issues-936-937-938-939 - #1065
Merged
Merged
Conversation
…6-937-938-939 fix: accessibility and i18n for charts, modal, form wizard, and WebSocket status
|
@El-Chapo-Npm Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four accessibility and i18n issues across the frontend.
Closes #936 - ChartsDashboard: accessible data-table alternatives
Each recharts-based chart in Charts.jsx (TransactionVolumeChart, BalanceHistoryChart, PortfolioPieChart, TransactionFlowChart) now renders a visually-hidden
alongside the visual chart. Screen readers can traverse the full dataset in tabular form without relying on the SVG.Closes #937 - FormWizard step progress indicator not announced
The progress bar wrapper in FormWizard.jsx now carries
ole="group" and �ria-label expressing the current step position (e.g. "Step 2 of 4"). Each active step gets �ria-current="step". A �ria-live="polite" region announces the new step title whenever the user navigates forward or back. Translations for ormWizard.progressLabel and ormWizard.stepAnnouncement are added to all 7 locale files.
Closes #938 - Modal does not restore focus on close
Modal.jsx now captures document.activeElement into a ref before moving focus into the dialog. When the effect cleanup runs (on close or unmount), focus is returned to that element, completing the expected WCAG dialog focus-management cycle.
Closes #939 - WebSocket connection status not localized
The raw wsStatus string and hard-coded 'Connection lost' copy in App.jsx are replaced with ('wsStatus.') lookups. A new wsStatus key group (connected, disconnected,
econnecting, ailed, and the label template) has been added to all 7 locale files (en, es, fr, pt, ar, he, zh).