feat(i18n): fix missing translations and implement locale parity checks - #1063
Merged
Conversation
|
@Folex1275 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Spanish/Hebrew stellarErrors and Arabic orphaned keys
Closes #934
Closes #935
Context
Spanish and Hebrew locales were missing 30 stellarErrors translation keys, causing users to see raw technical error codes (like
tx_bad_seq,op_underfunded) instead of localized messages when transactions fail. Arabic locale contained 84 orphaned keys from renamed/removed UI elements. No CI check existed to prevent future locale drift.Outcome
Details
Added stellarErrors translations:
frontend/src/i18n/locales/es.json- 30 Spanish translationsfrontend/src/i18n/locales/he.json- 30 Hebrew translationsRemoved orphaned keys:
frontend/src/i18n/locales/ar.json- Removed 84 keys (confirmation, qr, security, advanced, replay, and other deprecated namespaces)Added CI automation:
scripts/check-locale-parity.js- Validates key parity (exits 1 on drift)scripts/list-locale-diff.js- Debug helper for missing/extra keystests/i18n/locale-parity.test.js- Vitest test suitepackage.json- Addedtest:locale-parityto CI pipelinefrontend/src/i18n/locales/README.md- Maintenance guideVerification:
$ npm run test:locale-parity ✅ All locale files have matching keys! ✓ ar.json: 468 keys (0 missing, 0 extra) ✓ es.json: 468 keys (0 missing, 0 extra) ✓ fr.json: 468 keys (0 missing, 0 extra) ✓ he.json: 468 keys (0 missing, 0 extra) ✓ pt.json: 468 keys (0 missing, 0 extra) ✓ zh.json: 468 keys (0 missing, 0 extra)Testing
npm run test:locale-parity✅