[edited] uninstall should remove init-script and remember user to reboot

[mfaure]

Hi,

I've uninstalled orBot and orWall and have no more internet access. More precisely, it seems any DNS resolution is blocked. Here is my configuration:

Configuration

• Device : Samsung Galaxy S4 (GT-i9505)
• Android version : 4.4.4, rooted CyanogenMod 11.0-InstallerXNPQ32P, kernel 3.4.0-cyanogen-g433243c
• orWall version : not remembered as uninstalled (but installed around april 26th, 2015 from F-droid)
• IpTables content : "nothing" as I did (as root) an "iptable -Z"

Problem

• unable to acccess the internet.
  • From Firefox: "unable to locate host" (in french "adresse introuvable")
  • From Android browser: net::ERR_NAME_NOT_RESOLVED
• from terminal: ping www.free.fr gives unkonwn host: www.free.fr

Questions

• Is it an orWall issue or an orBot Issue ?
• How can I bring back the DNS resolution ? (and thus the 3G access)

PS :

• I followed the instructions for removal, and rebooted but issue is still present
• I already rebooted
• I don't have ClockWordMod but the phone is rooted

[cjeanneret]

Hello,

Small question: did you disable init-script before removing orwall? Orwall installs them in two locations:

• /system/etc/init.d
• /data/local/userinit.d/ (iff location exists)

Might be good to ensure there's nothing in both locations — also, when you invoke iptables it hits filter table only, you might get some other stuff in the nat table as well (iptables -vnL -t nat).

I think you might find a trailing init-script in the local directory. Guess I'll have to double-check it removes it if you disable init-script support :/.

Hope this helps.

Cheers,

C.

[mfaure]

Gosh, the 91Firewall script was still here (in /system/etc/init.d). I removed it from ADB this time (instead of the terminal app), and it seems to be good.

(By the way, I did not removed the script before uninstalling orWall but after when I discovered I had no more internet access).

As a conclusion, it seems there is a bug in removing the 91Firewall script at uninstall. Would you like me to run some more testing to troubleshoot this ?

Thank your very much for your help !

[cjeanneret]

Hello,

Unfortunately, we cannot remove the init-script(s) when we uninstall orwall: the uninstall action cannot be caught by the app itself in order to trigger some other pre-uninstall command :(.

You might want to check the "uninstall" part on the official web site: https://orwall.org/ ­— there are the explanation regarding the init-script part (though we should update it in order to add the other, local location).

Does it help?

Cheers,

C.

[mfaure]

Thank you, that's OK for me. Perhaps for other users, it would be useful to display a warning at uninstall, saying something like "hey, you absolutely need to finish uninstall manually with a terminal + link to uninstall doc".

Hope this helps

[patcon]

@mfaure There is a button (or rather, a toggle) in the app on the main screen that is intended to remove these scripts, so the intention is that terminal isn't needed. That's clearly not ideal, but you're not saying it's broken, are you? My impression was that you simply didn't notice it while you had the app installed? (totally understandable btw)

[mfaure]

I hadn't noticed this toogle, so I'm not saying it is broken :)

[patcon]

Would this work for us @cjeanneret?
https://stackoverflow.com/questions/18692571/how-it-works-warning-that-app-is-going-to-be-uninstalled

[cjeanneret]

hmm, good catch, @patcon! I'll give it a try… Well, whenever I get some spare time, probably next week if I'm not on the road. That would allow orwall to remove cleanly its init-scripts, and remember the reboot step.

[cjeanneret]

@mfaure I took the liberty to rename your bug in order to match the "enhancement" tag, as the issue was clearly a "not following uninstall steps" (which can be understandable, as it's not really userfriendly ;) ).
I'll try to follow @patcon finding in order to ensure orwall does cleanup its files before removal. Though this goes against everything I read so far in android papers — we'll see how it really works ;).

[laclaro]

Okay, I tried orwall, but uninstalled it again , when I noticed that it didn't integrate well with my other iptables-app.
Anyway. After the reboot I was not able to access the network anymore. I thought it was the custom rom, messing up things and reinstalled everything. Soon after, as I was trying orwall for a second time I realized that this network problem might have something to do with orwall not uninstalling properly.

As an experienced linux-user I fortunately could circumvent the problem after every reboot by flushing the iptables with
~$ su iptables -F
-> Very annoying! Because I realized this to be an orwall leftover script and came here.

I'm very sure, that many users (even though most tor-users are yet experienced), wouldn't find the way and blame the phone or something else. This is not a good way to go. Please do something about it! Displaying a warning is the least you can do!

Best regards,
Henning

[tdbe]

On my phone (OP2), orwall could NOT install the init-script (said so in its GUI), and no /system/etc/init.d or /data/local/userinit.d/ exists, but when I uninstall orwall, my dns is blocked just as described by OP.

After I restart, no network connections can be made. Tried ~$ su iptables -F, no change.

I can re-install orwall, and my internet comes back. But I can not get rid of it!

How can I debug this further?

PS: I also tried to set browser A to bypass and browser B to denied, paused orwall (both browser A and browser B worked), then uninstall it, then restarted, and afterwards both browser A and all other apps can't connect to anything.

[EDIT] I solved the problem by installing AFWall+. It allowed me to not only flush the rules but also overwrite them again (which is probably what orwall was also doing on every reinstall).