fix: deny Claude subagents by default - #605
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_d5a84835-a938-46cc-b00d-dd9b5298fbea) |
|
@codex review |
|
@coderabbitai review |
|
You need to increase your spend limit or enable usage-based billing to run background agents. Go to Cursor |
✅ Action performedReview finished.
|
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe default ingestion denylist now excludes Claude subagent transcript paths. Denylist attribution tests and watcher bridge integration tests were updated to validate the new policy and attribution behavior. ChangesClaude subagent denylist
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Test plan
Release note
Follow-up rider for the next patch release; no version metadata is changed here.
Note
Medium Risk
Default ingest scope changes for many Claude Code users (subagent transcripts no longer indexed unless overridden); behavior is localized to path policy and well-tested but affects production indexing.
Overview
Claude subagent JSONL under
~/.claude/projects/**/subagents/**are opt-out of ingestion by default via a new entry inDEFAULT_INGEST_DENYLIST, alongside the existing workflow (wf_*) pattern. Direct Claude project sessions and Codex/Cursor/Gemini paths are unchanged unless the user setsBRAINLAYER_INGEST_DENYLIST(including empty string to replace defaults entirely).Denylist and env override behavior are otherwise unchanged; subagent attribution parsing/cache code stays in place. Several denylist tests now assert
_claude_subagent_attributionwhere policy is path-driven, and the watcher pipeline test expects all Claude subagents (not only brain/workflow workers) to be blocked from indexing.Reviewed by Cursor Bugbot for commit 4bf1039. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Deny Claude subagent transcripts by default in ingest denylist
~/.claude/projects/**/subagents/**toDEFAULT_INGEST_DENYLISTin ingest_denylist.py, so Claude subagent transcripts are excluded from ingestion unless explicitly allowed._claude_subagent_attributionrather than through denylist policy.unknown_subagent_is_denylisted=Falseis set.Macroscope summarized 4bf1039.
Summary by CodeRabbit
New Features
Bug Fixes