feat: add achievement fingerprint discovery - #29
Merged
Conversation
`pnpm format:check` failed on seven files carried in on the fingerprint sweep commits, which would fail CI before any behaviour was reviewed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qh8Zb2HnaxebWrRLUMoAiv
recordRequest writes one row per physical Blizzard request, so the rolling-hour ledger grew by the whole hourly budget every hour with nothing to remove it; maintenance cleanup only covered rate limits, negative cache, and suppressions. Prune on requested_at rather than the owning reservation: a request stops counting towards the rolling hour on its own timestamp, and a reservation can expire while its late requests are still inside the window, so deleting by reservation would silently undercount the shared budget and admit an overlapping sweep. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qh8Zb2HnaxebWrRLUMoAiv
The worker now refuses to start without BLIZZARD_CLIENT_ID, BLIZZARD_CLIENT_SECRET, and BLIZZARD_SWEEP_REQUEST_CAP, but .env.example still described the pre-fingerprint worker, so a fresh local checkout could not boot it. MAINTAINER_ALERT_WEBHOOK_URL was undocumented in both the example and the Railway guide. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qh8Zb2HnaxebWrRLUMoAiv
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the approved Blizzard achievement-fingerprint discovery design, including private worker credentials, FIFO shared-budget admission, atomic snapshots, privacy exclusion, and provenance-free public output.\n\nVerification is tracked by required CI; local focused migration/unit/integration checks pass.