Skip to content

ci: fix version workflow#424

Merged
dd-oleksii merged 1 commit into
mainfrom
oleksii/jj-srwqnylupovw
Jul 22, 2026
Merged

ci: fix version workflow#424
dd-oleksii merged 1 commit into
mainfrom
oleksii/jj-srwqnylupovw

Conversation

@dd-oleksii

Copy link
Copy Markdown
Collaborator

version workflow is failing with the following error:

> ruby-sdk@3.8.1 postversion
> ./postversion.sh

+ jq -r .version ./package.json
+ VERSION=3.8.1
+ cargo set-version -p eppo_client 3.8.1
Error: `cargo metadata` exited with an error:     Updating crates.io index
error: failed to select a version for the requirement `eppo_core = "=10.0.1"`
candidate versions found which didn't match: 10.0.0, 9.3.0, 9.2.0, ...

This is likely caused by cargo not finding the eppo_core inside ruby workspace.

Set the eppo_core override in ~/.cargo/config.toml.

Additional fixes:

  • pin cargo-edit to a specific version
  • replace sed's -i option with manual handling of tmp file to make it portable across linux and macos

version workflow is failing with the following error:

    > ruby-sdk@3.8.1 postversion
    > ./postversion.sh

    + jq -r .version ./package.json
    + VERSION=3.8.1
    + cargo set-version -p eppo_client 3.8.1
    Error: `cargo metadata` exited with an error:     Updating crates.io index
    error: failed to select a version for the requirement `eppo_core = "=10.0.1"`
    candidate versions found which didn't match: 10.0.0, 9.3.0, 9.2.0, ...

This is likely caused by cargo not finding the eppo_core inside ruby
workspace.

Set the eppo_core override in ~/.cargo/config.toml.

Additional fixes:
- pin cargo-edit to a specific version
- replace sed's -i option with manual handling of tmp file to make it
  portable across linux and macos
@dd-oleksii
dd-oleksii requested a review from aarsilv July 22, 2026 03:08
@changeset-bot

changeset-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c4355ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aarsilv aarsilv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the automated “Prepare release” versioning workflow by making Rust workspace/version updates reliable in CI and improving script portability across macOS/Linux.

Changes:

  • Pin cargo-edit to a specific version in the version workflow.
  • Add a CI-time Cargo override so cargo-edit can resolve the local eppo_core crate from nested workspaces.
  • Make sed usage portable by replacing -i with a temp-file + mv pattern in SDK postversion.sh scripts.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
ruby-sdk/postversion.sh Switches to temp-file rewrite for portable version.rb updates.
elixir-sdk/postversion.sh Switches to temp-file rewrite for portable mix.exs version updates.
.github/workflows/version.yml Pins cargo-edit and writes a Cargo config patch so workspace crate resolution succeeds in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +45 to +48
run: |
mkdir -p ~/.cargo/
echo "[patch.crates-io.eppo_core]" >> "${CARGO_HOME:-$HOME/.cargo}/config.toml"
echo "path = '$PWD/eppo_core'" >> "${CARGO_HOME:-$HOME/.cargo}/config.toml"
@dd-oleksii
dd-oleksii merged commit 75baf85 into main Jul 22, 2026
20 checks passed
@dd-oleksii
dd-oleksii deleted the oleksii/jj-srwqnylupovw branch July 22, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants