Repository navigation
cli-adjudicate-exit-code: fix CLI-01 - #45
Merged
Merged
Conversation
kridaydave
force-pushed
the
fix/pr-30-cli-adjudicate-exit-code
branch
from
November 8, 2026 18:08
045129e to
d6c3195
Compare
kridaydave
force-pushed
the
fix/pr-30-cli-adjudicate-exit-code
branch
from
November 8, 2026 19:06
f471a27 to
6d2e9ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs
What was wrong
src/main.rs:271 docket branch returned ExitCode::SUCCESS unconditionally, unlike store/VCS/dir paths which return exit_code_for(verdict).
Fix
Return Ok(exit_code_for(d.verdict)) in the --docket branch so Adjudicated exits 0 and Blocked/Cloaked/Embargoed exit 1. Update test_cli_adjudicate_load_docket (fixture is EMBARGOED) to assert exit code 1.
Verification
CI green (fmt, clippy, tests, release build, adjudication) + the regression test you added