-
Notifications
You must be signed in to change notification settings - Fork 7
Plot vs z #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
steven-murray
wants to merge
15
commits into
main
Choose a base branch
from
plot-vs-z
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Plot vs z #39
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
dec0ed7
feat: plot_vs_z
70de431
feat: add plot_vs_z function
de1cc21
add cli tests and fig cleanup
JitenDhandha 10cf16a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2dc46bb
improve legend labeling
JitenDhandha f07d904
Improve plot function parity
JitenDhandha 8fc6649
Clean up plot option docs and naming
JitenDhandha e469ee8
add/fix plot tests
JitenDhandha a247225
more code polishing
JitenDhandha cc793fe
update and polish README/tutorial
JitenDhandha cf70d88
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8cf9bc6
k range in plot-vs-z legend
JitenDhandha c8e7836
redundant func, select_k_and_z_ranges allows None
JitenDhandha b5a67be
more k-options for plot-vs-z
JitenDhandha 86b0d05
some cleanup
JitenDhandha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ## Environment | ||
|
|
||
| - Use the `uv` python environment to run code. | ||
|
|
||
| ## Tests | ||
|
|
||
| - Write tests using the pytest framework, in `tests/` | ||
| - Run narrow tests based on implemented features first, using `uv run pytest -k "test-identifier"` | ||
| - Always write a failing test before fixing a bug. | ||
| - Write tests of intended behaviour before implementing a feature. | ||
|
|
||
| ## Style | ||
|
|
||
| - Prefer adding type annotations for new parameters and functions, wherever reasonable. | ||
| - Always run `uv run ruff format` and `ruff check --fix` before closing the loop. |
Binary file renamed
BIN
+637 KB
docs/source/_static/eor_limits.png → ...urce/_static/test_lib_plot_vs_k_basic.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these being added to the dev group? Surely pip is installed already since
uvuses it. And why ipykernel vs jupyter?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uvactually does not usepipso it needs to be installed explicitly if you want it. I added these so that I could use theuvenvironment as a jupyter kernel in VSCode. I wasn't entirely sure if this is a good idea to add here. They are dev requirements, but only because I was developing in a particular modality. I can remove them if we think that's better.