Inclusion of keyword arguments#9
Open
JulStraus wants to merge 3 commits into
Open
Conversation
lfbernardino
left a comment
lfbernardino
left a comment
Collaborator
There was a problem hiding this comment.
The additions look straightforward. The incorporation of op_per_strat is solely related to the units of the strategic parameters at this point, as the model is still focusing on operational models (i.e. defined in a single strategic period).
| The following points should be accounted for when setting up a problem in [`EnergyModelsRecedingHorizon`](@ref): | ||
|
|
||
| - The provided case object should be an [`EMB.Case`](@extref EnergyModelsBase.Case) with problem horizons included in the case object through the `misc` dictionary using the `:horizons` key. | ||
| - The modetype object must be a subtype of [`RecHorEnergyModel`](@ref EMRH.RecHorEnergyModel) for dispatching purposes.- The provided case object should be an [`Case`](@extref EnergyModelsBase.Case) with problem horizons included in the case object through the `misc` dictionary using the `:horizons` key. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - The modetype object must be a subtype of [`RecHorEnergyModel`](@ref EMRH.RecHorEnergyModel) for dispatching purposes.- The provided case object should be an [`Case`](@extref EnergyModelsBase.Case) with problem horizons included in the case object through the `misc` dictionary using the `:horizons` key. | |
| - The modeltype object must be a subtype of [`RecHorEnergyModel`](@ref EMRH.RecHorEnergyModel) for dispatching purposes. | |
| - The provided case object should be an [`Case`](@extref EnergyModelsBase.Case) with problem horizons included in the case object through the `misc` dictionary using the `:horizons` key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two keyword arguments:
use_op_per_stratis a Boolean that can be utilized to adjust the reference value for parameters indexed over strategic periods. In the previous version, these parameters were always based on a duration of 1 of an operational period while the new keyword argument allows to include a parameterop_per_stratto the providedTimeStructureto specify the reference.optimizer_paramwhich can be utilized for providing optimizer parameters.