Enhance/wind farm parameters#15
Draft
Zetison wants to merge 5 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the wind-power sampling interface by extending WindFarmParameters and wiring the new options through to the Python wind_power_timeseries call, with corresponding test updates.
Changes:
- Extend
WindFarmParameterswithturbine_power_curve,sigma, andwakeloss, and changeorientation/shapedefaults tonothingwithshapenow numeric. - Convert a Julia
DataFramepower curve into a PandasSeriesbefore calling the Python sampler. - Update/extend wind-power tests and test utilities to reflect the new parameters and a shorter test horizon.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/datastructures.jl |
Adds new wind parameters, validates them, and passes them through to the Python sampler. |
src/utils.jl |
Adds to_pandas_series helper for converting a power-curve DataFrame to Pandas. |
test/utils.jl |
Updates wind test graph helper to accept/pass new parameters and uses a shorter horizon. |
test/test_windpower.jl |
Updates parameter tests, adds validation tests, and refactors wind mathematical formulation tests. |
test/runtests.jl |
Adds DataFrames import for test usage. |
test/Project.toml |
Adds DataFrames as a test dependency. |
NEWS.md |
Updates release notes describing the wind parameter extensions. |
docs/src/library/internals/methods-EMLI.md |
Adds to_pandas_series to the internal methods list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables more options from sampling the
wind_power_timeseriesrepository. The PR depends on this MR to be merged with main.WindFarmParametersto include an optionalturbine_power_curveargument, which allows users to specify a custom power curve for the wind turbine.The
turbine_power_curveis expected to be aDataFramewith columnswind_speedandpower_curve, wherewind_speedrepresents the wind speed values (in m/s) andpower_curverepresents the corresponding power output of the turbine at those wind speeds.sigmaandwakelosswere also added toWindFarmParametersto enable all options of thewind_power_timeseriesrepository.shapeparameter was corrected from a string to a float.