ci(actions): bump Node to 24 so jsdom 30 can install - #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI has been failing on #333 (dependabot bumping jsdom 29.1.1 → 30.0.1) since it opened, so auto-merge never completes. All 64 tests pass; the run dies on an unhandled error while starting the vitest worker:
jsdom 30 dropped Node 20:
jsdom@29.1.1^20.19.0 || ^22.13.0 || >=24.0.0^7.25.0jsdom@30.0.1^22.22.2 || ^24.15.0 || >=26.0.0^8.9.0markAsUncloneablecomes fromworker_threadsand does not exist in Node 20, so undici 8 throws as it loads. The log shows severalnpm warn EBADENGINEimmediately before the failure.Change
node-version: 20→24in bothci.ymlanddeploy.yml. Node 24 is the current LTS and its latest (24.19.0) satisfies jsdom 30's^24.15.0.deploy.ymlis included because it also runsnpm test, so it would fail the same way once jsdom 30 lands.Verification
Run locally against a downloaded Node 24.19.0, since a bump should be tested on the version being pinned:
main)npm run buildwith jsdom 30EBADENGINEwarningsOnly the workflows are committed — jsdom was bumped locally to test, then
package.jsonandpackage-lock.jsonwere reverted, since that bump belongs to #333.Follow-up, not done here
There is no
enginesfield inpackage.jsonand no.nvmrc, so nothing warns when the local and CI Node versions diverge. Adding either would have caught this before dependabot did.