feat: treat pull: true as a default git pull - #773
Merged
Merged
Conversation
YAML true was passed through as git pull arguments, so pull: true ran `git pull true` instead of a default pull. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughChangesPull Input Support
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant PullInput
participant parseBoolOrGitArgs
participant pullFromRemote
participant Git
PullInput->>parseBoolOrGitArgs: parse boolean or Git arguments
parseBoolOrGitArgs->>pullFromRemote: return true or argument string
pullFromRemote->>Git: run normalized pull arguments
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EndBug
marked this pull request as ready for review
August 14, 2026 21:02
EndBug
enabled auto-merge (squash)
August 14, 2026 21:09
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull: trueas a defaultgit pull(no extra args), matchingfetch/push.falseor omit still skips pull; other strings remain git pull arguments.truewas previously passed through asgit pull true. The" "workaround still does not work (inputs are trimmed); usepull: trueinstead.with: true.Test plan
pull: truepulls remote commits, then commits local changes (does not rungit pull true)pull: falseand omittedpullskip pullpull: '--rebase --autostash'still pulls with those argsdry_run: true+pull: truelogsWould pull from remote.and does not mutate the reponpm test(unit + integration + lint) afternpm run buildMade with Cursor
Summary by CodeRabbit
New Features
pulloption now supports default pulls, disabling pulls, or custom Git pull arguments.Bug Fixes
Tests