Feat add nvcomp - #9
Open
EmilDohne wants to merge 33 commits into
Open
Conversation
Detect the installed CUDA toolkit and drive both the nvcomp redistributable variant and GPU architectures from it instead of hardcoding, fixing illegal-memory-access crashes on newer GPUs (e.g. Blackwell/sm_120) whose device code was never built. - New cmake/setup_cuda.cmake: correct find_package(CUDAToolkit), resolve COMPRESSED_IMAGE_CUDA_MAJOR (AUTO or 11/12/13 override), and default CMAKE_CUDA_ARCHITECTURES to "native" (overridable). - fetch_nvcomp.cmake: pick nvcomp version + SHA256 per CUDA major (11 -> 5.0.0.6, 12/13 -> 5.2.0.10, since 5.2 dropped cuda11). - Remove the broken find_package(CUDAToolkit REQUIRED <optname>) and the misused option() for the CUDA version. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.