Change fee settings from UI by markettes · Pull Request #516 · Elenpay/NodeGuard

markettes · 2026-05-15T14:25:00Z

Enhance the UI for changing fee settings.

…itory

…mplement it in LightningClientService

…age channel fee policies

…s to manage channel fee policies

…s in ChannelRepository and Lightning services

…eePolicy method

Jossec101

Please introduce validation so:

Inbound base and fee rate are negative only
In abs terms, both inbound base and fee rate cannot be bigger than it's counterparter (you cannot surcharge positively a routing, only discount)
The ui shall require negatives values
Introduce a default for CLTV (40 blocks its ok), add to constants pls
Also modify channel request view to set fee rates at creation https://lightning.engineering/api-docs/api/lnd/lightning/open-channel/#lnrpcopenchannelrequest

Jossec101 · 2026-05-21T11:40:41Z

Please introduce validation so:

Inbound base and fee rate are negative only

In abs terms, both inbound base and fee rate cannot be bigger than it's counterparter (you cannot surcharge positively a routing, only discount)

The ui shall require negatives values

Introduce a default for CLTV (40 blocks its ok), add to constants pls

Also modify channel request view to set fee rates at creation https://lightning.engineering/api-docs/api/lnd/lightning/open-channel/#lnrpcopenchannelrequest

@markettes I guess you are still on this

- Introduced a new column `RequestMetadata` in the `ChannelOperationRequests` table to store additional request information. - Updated the `ApplicationDbContextModelSnapshot` to reflect the new `RequestMetadata` column. - Enhanced the Channel Requests page to include fields for setting the initial channel base fee and fee rate. - Implemented logic in the `LightningService` to handle the new fee policy parameters when creating open channel requests. - Added unit tests to verify the creation of open channel requests with the initial channel fee policy.

markettes · 2026-05-22T14:02:21Z

Please introduce validation so:

Inbound base and fee rate are negative only

In abs terms, both inbound base and fee rate cannot be bigger than it's counterparter (you cannot surcharge positively a routing, only discount)

The ui shall require negatives values

Introduce a default for CLTV (40 blocks its ok), add to constants pls

Also modify channel request view to set fee rates at creation https://lightning.engineering/api-docs/api/lnd/lightning/open-channel/#lnrpcopenchannelrequest

@markettes I guess you are still on this

Yep, you can check now

Copilot

Pull request overview

Adds UI and backend support for configuring Lightning channel fee policy both at channel creation time (initial routing policy) and for existing channels (fee policy management), persisting new request metadata to survive approval/execution.

Changes:

Persist initial channel fee policy (base fee / fee rate) on ChannelOperationRequest via a new RequestMetadata column and expose it through NotMapped convenience properties.
Apply initial fee policy values when building LND OpenChannelRequest in LightningService, with range validation.
Extend the Channels UI with a “Fee Policy” management tab (incl. inbound fee policy fields) and add UI fields to Channel Requests for initial fee policy input/display.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/NodeGuard.Tests/Services/LightningServiceTests.cs	Adds a test covering `OpenChannelRequest` creation when initial fee policy is provided.
src/Services/LightningService.cs	Applies optional initial fee policy values onto LND `OpenChannelRequest` with validation.
src/Pages/Channels.razor	Adds a tabbed channel management modal with a new Fee Policy form and save flow.
src/Pages/ChannelRequests.razor	Adds UI to enter/display initial channel fee policy values on open-channel requests.
src/Data/Models/ChannelOperationRequest.cs	Introduces `RequestMetadata` persistence and `InitialChannel*` accessors backed by JSON.
src/Helpers/Constants.cs	Adds configurable default timelock delta constant for fee policy form defaults.
src/Migrations/20260522125854_AddRequestMetadata.cs	Migration adding `RequestMetadata` to `ChannelOperationRequests`.
src/Migrations/20260522125854_AddRequestMetadata.Designer.cs	EF migration designer snapshot for the added column.
src/Migrations/ApplicationDbContextModelSnapshot.cs	Updates model snapshot to include `RequestMetadata` on `ChannelOperationRequest`.

Files not reviewed (1)

src/Migrations/20260522125854_AddRequestMetadata.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Created a new migration to add InitialChannelBaseFeeMsat and InitialChannelFeeRatePpm columns to the ChannelOperationRequests table. - Updated the ApplicationDbContextModelSnapshot to reflect the new columns in the ChannelOperationRequests entity.

Jossec101 · 2026-05-26T09:06:26Z

+                                            <Validation Validator="ValidateChannelFeeRatePpm">
+                                                <FieldLabel>Fee rate (ppm)</FieldLabel>
+                                                <FieldHelp>Outbound proportional fee in parts per million.</FieldHelp>
+                                                <NumericEdit TValue="long?" Min="0L" Max="@((long)uint.MaxValue)"
+                                                                @bind-Value="_channelFeePolicy.FeeRatePpm">
+                                                    <Feedback>
+                                                        <ValidationError />
+                                                    </Feedback>
+                                                </NumericEdit>
+                                            </Validation>


@markettes can we please add here the current channel fee rate? same for inbound

Jossec101 · 2026-05-26T09:08:04Z

+        var defaultChannelFeePolicyTimelockDeltaBlocks = Environment.GetEnvironmentVariable("DEFAULT_CHANNEL_FEE_POLICY_TIMELOCK_DELTA_BLOCKS");
+        if (defaultChannelFeePolicyTimelockDeltaBlocks != null) DEFAULT_CHANNEL_FEE_POLICY_TIMELOCK_DELTA_BLOCKS = int.Parse(defaultChannelFeePolicyTimelockDeltaBlocks);


Could also add defaults for fee policies? so we dont rely on LND conf (harder to change)

wdyt about setting this at node level?

Done 🏁
Maybe the idea of setting the default fees at node level in NG can be implemented in the future

Jossec101 · 2026-05-26T09:12:25Z

+                                        <FieldHelp>CLTV delta advertised for forwarded HTLCs on this channel.</FieldHelp>
+                                        <NumericEdit TValue="long?" Min="0L" Max="@((long)uint.MaxValue)"
+                                                        @bind-Value="_channelFeePolicy.TimeLockDelta">
+                                            <Feedback>


Can we add to this list in the datagrid also a way to see really quick PPM? both inbound and outbound but also what they charge to us (peer policy?) Perhaps peer policy is a tooltip or something, its dense info i let you figure but I think it adds value

…or handling

markettes and others added 13 commits May 6, 2026 09:46

feat: add GetByOutpoint method to ChannelRepository and IChannelRepos…

e388880

…itory

feat: add SetChannelFeePolicy method to ILightningClientService and i…

7b4f707

…mplement it in LightningClientService

feat: implement SetChannelFeePolicy method in LightningService to man…

a46b83a

…age channel fee policies

feat: add SetChannelFeePolicy RPC method and request/response message…

79cd124

…s to manage channel fee policies

feat: add unit tests for SetChannelFeePolicy and GetByOutpoint method…

af71241

…s in ChannelRepository and Lightning services

Merge branch 'main' into feat/set-channel-fee-policy

bf09174

Merge branch 'main' into feat/set-channel-fee-policy

a9e00a8

fix: control node is a channel participant

f52022e

test: add test for not participant node

0a3afb2

feat: add details for the fields

d53536c

feat: add validation for inbound fee policy parameters in SetChannelF…

f894922

…eePolicy method

Merge branch 'main' into feat/set-channel-fee-policy

db6c3ba

feat: add UI to change fee settings for a channel

b11ca57

Jossec101 requested changes May 18, 2026

View reviewed changes

markettes force-pushed the feat/set-channel-fee-policy branch from db6c3ba to 1859a5a Compare May 19, 2026 08:53

Jossec101 self-requested a review May 19, 2026 09:02

Base automatically changed from feat/set-channel-fee-policy to main May 19, 2026 10:20

markettes added 3 commits May 19, 2026 14:38

Merge branch 'main' into feat/UI-change-channel-fees

b0d508b

fix: allow only negative values for inbound fees

927b09d

feat: add default channel fee policy timelock delta blocks

c8b1e91

markettes requested a review from Copilot May 22, 2026 14:01

Copilot started reviewing on behalf of markettes May 22, 2026 14:02 View session

Copilot AI reviewed May 22, 2026

View reviewed changes

Comment thread src/Pages/Channels.razor Outdated

Comment thread src/Pages/Channels.razor

Jossec101 reviewed May 25, 2026

View reviewed changes

Comment thread src/Migrations/ApplicationDbContextModelSnapshot.cs Outdated

Jossec101 reviewed May 26, 2026

View reviewed changes

markettes and others added 6 commits May 26, 2026 12:18

feat: enhance channel node management checks with macaroon validation

e98375b

Merge branch 'main' into feat/UI-change-channel-fees

b8678e0

feat: add GetChannelFeePolicy method to retrieve channel fee policies

1694aab

feat: add GetChannelFeePolicy tests for channel fee retrieval and err…

7f5df90

…or handling

feat: add the current fee rate to management tab and channels datagrid

c373ac5

feat: add default values for the channel fees

1c551a8

markettes requested a review from Jossec101 May 29, 2026 18:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change fee settings from UI#516

Change fee settings from UI#516
markettes wants to merge 24 commits into
mainfrom
feat/UI-change-channel-fees

markettes commented May 15, 2026

Uh oh!

Jossec101 left a comment

Uh oh!

Jossec101 commented May 21, 2026 •

edited

Loading

Uh oh!

markettes commented May 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jossec101 May 26, 2026 •

edited

Loading

Uh oh!

markettes May 29, 2026

Uh oh!

Jossec101 May 26, 2026

Uh oh!

markettes May 26, 2026

Uh oh!

markettes May 29, 2026

Uh oh!

Jossec101 May 26, 2026

Uh oh!

markettes May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		var defaultChannelFeePolicyTimelockDeltaBlocks = Environment.GetEnvironmentVariable("DEFAULT_CHANNEL_FEE_POLICY_TIMELOCK_DELTA_BLOCKS");
		if (defaultChannelFeePolicyTimelockDeltaBlocks != null) DEFAULT_CHANNEL_FEE_POLICY_TIMELOCK_DELTA_BLOCKS = int.Parse(defaultChannelFeePolicyTimelockDeltaBlocks);

Conversation

markettes commented May 15, 2026

Uh oh!

Jossec101 left a comment

Choose a reason for hiding this comment

Uh oh!

Jossec101 commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markettes commented May 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jossec101 May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markettes May 29, 2026

Choose a reason for hiding this comment

Uh oh!

Jossec101 May 26, 2026

Choose a reason for hiding this comment

Uh oh!

markettes May 26, 2026

Choose a reason for hiding this comment

Uh oh!

markettes May 29, 2026

Choose a reason for hiding this comment

Uh oh!

Jossec101 May 26, 2026

Choose a reason for hiding this comment

Uh oh!

markettes May 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jossec101 commented May 21, 2026 •

edited

Loading

Jossec101 May 26, 2026 •

edited

Loading