🎨 Palette: Highlight keyboard shortcuts - #275
Conversation
Wrapped the custom keyboard shortcut instructions ("Space" and "↑") in semantic `<kbd>` tags in `mario-game.njk` to drastically improve their discoverability and visual distinction against the game's background. Also updated the `.Jules/palette.md` journal with this critical UX learning.
Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added semantic
<kbd>tags and physical-key styling to the text instructions for jumping in the Mario game.🎯 Why: Users playing web-based games often overlook plain text instructions. Formatting them as distinct physical keys makes the required keyboard interactions immediately obvious and intuitive.
📸 Before/After: The instructions changed from plain text to highlighted, shadow-bordered keycap shapes that stand out clearly against the blue sky background.
♿ Accessibility: Improves semantic markup by explicitly defining keyboard inputs using the native HTML
<kbd>element, which is the correct semantic element for user input.Note on constraints: Custom CSS was appended to the internal
<style>block inmario-game.njkbecause this specific file does not utilize a utility class framework (like Tailwind) and relies entirely on its own internal<style>block for layout and design. Adding the new selector directly to the existing block is the cleanest and most consistent way to integrate the enhancement without refactoring the page.PR created automatically by Jules for task 313597686587067868 started by @EiJackGH