This repository was archived by the owner on May 13, 2026. It is now read-only.
refactor(progress): dedupe 4 identical SystemTime::now() blocks via now_secs() helper - #705
Merged
Merged
Conversation
…ow_secs() helper Replaces 4 identical SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs() chains in Job::new/update_progress/complete/fail with a single private now_secs() helper. Behavior-preserving (preserves .unwrap_or_default semantics — returns 0 on clock-before-epoch). Single-file change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces 4 identical
SystemTime::now()...unwrap_or_default().as_secs()chains inJob::new/update_progress/complete/failwith a single privatenow_secs()helper at the top ofcrates/core/src/progress.rs.Behavior-preserving (preserves
.unwrap_or_default()semantics — returns 0 on clock-before-epoch). Single-file change. Net: -16/+11 LOC.Verification
cargo fmt --check— cleancargo clippy --workspace --all-targets -- -D warnings— cleancargo test --workspace --all-targets— all greenrg -n 'SystemTime::now\(\)' crates/core/src/progress.rs— 1 hit (helper definition)