ci: check sim_string_list.h stays in sync with string_list.h - #7720
Merged
Merged
Conversation
Extends the codegen drift workflow with a gen-simstr Justfile recipe and matching CI job, so a stale sim_string_list.h (as fixed in #7718) is caught automatically instead of relying on manual review. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The edgetx-dev image now ships just and m4 (EdgeTX/build-edgetx#54), so the per-job install/pin in the codegen drift action is redundant for anything running inside that image. The `changes` job keeps its own install since it runs on a bare ubuntu-latest runner, not the container. Depends on EdgeTX/build-edgetx#54 reaching ghcr.io/edgetx/edgetx-dev:latest before merging, or these jobs will fail with `just: command not found`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
A ::warning:: annotation on an otherwise green job is easy to miss. None of these jobs are required status checks on main, so failing them is safe: it surfaces genuine drift on the PR without blocking a contributor who lacks the local toolchain from merging. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
radio/src/translations/sim_string_list.his generated fromstring_list.hviam4 simstr.m4 string_list.h > sim_string_list.h, but nothing enforced that it stayed regenerated. chore: update sim_string_list.h to match string_list.h #7718 fixed drift that had crept in; this adds a CI check so that class of drift is caught automatically instead of relying on manual review.codegen_driftworkflow (used for fonts/cfn-sort/YAML parsers/radio list) with a newgen-simstrJustfile recipe and matchingsimstrjob.edgetx-devimage now shipsjustandm4(dev: add just and m4 build-edgetx#54), so the per-jobjustinstall/pin is dropped — only thechangesjob (which runs on a bareubuntu-latestrunner, not the container) still installs it.codegen_driftjobs (cfn-sort, fonts, yaml, radios, simstr) to fail on drift instead of only posting a::warning::annotation. None of these are required status checks onmain, so this doesn't block anyone without the local toolchain — it just makes real drift visible as a red ✗ on the PR instead of a warning buried in an otherwise-green run.Test plan
just gen-simstrreproduces the exact drift chore: update sim_string_list.h to match string_list.h #7718 fixed (locally, against the pre-chore: update sim_string_list.h to match string_list.h #7718 tree)gen-radios,cfn-sort,gen-fonts,gen-yaml) have pre-existing drift onmain, so switching them to fail-on-drift won't surface an unrelated false failuresimstrjob and confirms the other four still pass🤖 Generated with Claude Code