Skip to content

Add compile time option for xlite alt layout - #2662

Closed
netmute wants to merge 3 commits into
EdgeTX:mainfrom
netmute:main
Closed

netmute wants to merge 3 commits into
EdgeTX:mainfrom
netmute:main

Conversation

@netmute

@netmute netmute commented Oct 31, 2022

Copy link
Copy Markdown

This adds a compile time option to switch to an alternative layout for the FrSky X-Lite transmitters. It swaps joystick and dpad functions.

Original
original

New
alternative

@raphaelcoeffic

Copy link
Copy Markdown
Member

Once we move to more generic drivers, this should be easily done at runtime (see #2631)

@pfeerick

Copy link
Copy Markdown
Member

Just expanding on that a bit - one of our goals is to have as few as possible compile-time options / reducing the number that there currently are. Some are unavoidable, and that's fine. But while we still have the SRAM and FLASH space to do so, as much stuff as possible will be made a runtime option.

@netmute

netmute commented Nov 1, 2022

Copy link
Copy Markdown
Author

I'd love to see this as a runtime option!

@raphaelcoeffic

Copy link
Copy Markdown
Member

@netmute Could you please rebase this PR on top of current main? As we're transitioning to defining keys in targets by means of a JSON hardware definition file, this PR will get hard to support as-is in the future. We might have to find some clever way for key remapping, but in the meantime, I could imagine having that merged soon once rebased. Just mark the PR as "Ready for review" once you're done.

@raphaelcoeffic
raphaelcoeffic marked this pull request as draft August 12, 2023 05:28
@netmute
netmute marked this pull request as ready for review October 10, 2024 15:41
@netmute

netmute commented Oct 10, 2024 •

Copy link
Copy Markdown
Author

@raphaelcoeffic Sorry it took more than a year, life happened 🙈

@baldermatt

Copy link
Copy Markdown

I'm definitely looking forward to this option becoming available for my xlite! The joystick has failed on mine and I'd really like to regain full functionality again. Thanks for the work you all put in towards helping out the community!

@baldermatt

Copy link
Copy Markdown

@raphaelcoeffic I'm hoping to implement this onto my Xlite in the near future. Could you provide an estimate on when this functionality will be available?

@pfeerick

Copy link
Copy Markdown
Member

Runtime option is unlikely to happen - the X-Lite is a STM32 F2 - and support for F2 is officially dropped as of EdgeTX 2.12 onwards, hence why 2.11 is continuing to be updated as a long term support release for those radios. However, it will primarily only receive bugfixes, not new features. The best I think we can offer now is to rebase this, and merge it as a compile-time option (rather than lose it entirely).

@pfeerick
pfeerick changed the base branch from main to 2.11 September 25, 2026 04:59
@pfeerick
pfeerick changed the base branch from 2.11 to main September 25, 2026 05:00
pfeerick pushed a commit that referenced this pull request Sep 25, 2026
…2662)

Adds the XLITE_ALT_LAYOUT CMake option (X-Lite and X-Lite S), which swaps
the key and left-trim GPIO assignments.

Squash of PR #2662 (commit 39bf1c4; the PR's two merge-from-main
commits dropped), hand-ported to 2.11: pin definitions converted to the
LL style (GPIOx / LL_GPIO_PIN_n), and TRIMS_VIRTUAL_RV/RH added to the
alternative trim block so the virtual right-stick trims are still
generated, as in the stock X-Lite layout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pfeerick pfeerick mentioned this pull request Sep 25, 2026
19 of 21 tasks
@pfeerick

Copy link
Copy Markdown
Member

Will be included via #7816 given the upstream for is tracking main branch rather than being in it's own feature branch.

@pfeerick pfeerick closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants