update rejoin - #453
Open
sleaze5 wants to merge 2 commits into
Open
Conversation
Updated the rejoin command to include repositioning functionality.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the rejoin command to optionally persist and restore the player’s position across the teleport by sending teleport data and running a queued respawn handler after rejoin.
Changes:
- Extends
rejoin / rjto accept an optional reposition flag and attempts to carry the current character pivot through TeleportService teleport data. - Adds a queued-on-teleport handler intended to re-pivot the character shortly after loading.
- Updates the command list entry to reflect the new argument.
Comments suppressed due to low confidence (1)
source:6956
- The reposition flag currently stores
speaker.Character:GetPivot()directly into teleportData. If teleportData needs to be serializable, this should be encoded into primitives (e.g., CFrame components) to match the respawn handler's decode logic.
local data = nil
if parseBoolean(args[1], false) == true then
if queueteleport then
if speaker.Character then data = speaker.Character:GetPivot() end
queueteleport(teleportRespawnHandler)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
big fan of the teleport data set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the rejoin command to include repositioning functionality.