Remove deprecated get_package_share_directory#71
Closed
fmrico wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the map manager plugins to stop using the deprecated ament_index_cpp::get_package_share_directory() API by switching to ament_index_cpp::get_package_share_path() and std::filesystem path composition for building map file paths.
Changes:
- Replaced
get_package_share_directory()withget_package_share_path()across the updated map managers. - Switched string path concatenation to
std::filesystem::pathjoining for map file resolution. - Added
<filesystem>includes where needed to support the new path API.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| maps_managers/easynav_simple_maps_manager/src/easynav_simple_maps_manager/SimpleMapsManager.cpp | Use get_package_share_path() and std::filesystem for map path construction. |
| maps_managers/easynav_routes_maps_manager/src/easynav_routes_maps_manager/RoutesMapsManager.cpp | Use get_package_share_path() and std::filesystem join for route YAML path. |
| maps_managers/easynav_navmap_maps_manager/src/easynav_navmap_maps_manager/NavMapMapsManager.cpp | Use get_package_share_path() and std::filesystem for occ/nav map file paths. |
| maps_managers/easynav_costmap_maps_manager/src/easynav_costmap_maps_manager/CostmapMapsManager.cpp | Use get_package_share_path() and std::filesystem for costmap YAML path. |
| maps_managers/easynav_bonxai_maps_manager/src/easynav_bonxai_maps_manager/BonxaiMapsManager.cpp | Use get_package_share_path() and std::filesystem for bonxai/occ map paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+24
to
25
| #include "ament_index_cpp/get_package_share_path.hpp" | ||
| #include "ament_index_cpp/get_package_prefix.hpp" |
Comment on lines
+67
to
+68
| pkgpath = ament_index_cpp::get_package_share_path(package_name); | ||
| map_path_ = (pkgpath / map_path_file).string(); |
Comment on lines
+114
to
+115
| const std::filesystem::path pkgpath = ament_index_cpp::get_package_share_path(package_name); | ||
| map_path_ = (pkgpath / map_path_file).string(); |
Comment on lines
+126
to
+127
| const std::filesystem::path pkgpath = ament_index_cpp::get_package_share_path(package_name); | ||
| map_path_ = (pkgpath / occmap_path_file).string(); |
Comment on lines
+149
to
+150
| const std::filesystem::path pkgpath = ament_index_cpp::get_package_share_path(package_name); | ||
| map_path_ = (pkgpath / navmap_path_file).string(); |
Comment on lines
+77
to
+78
| const std::filesystem::path pkgpath = ament_index_cpp::get_package_share_path(package_name); | ||
| map_path_ = (pkgpath / bonxai_path_file).string(); |
Comment on lines
+110
to
+111
| const std::filesystem::path pkgpath = ament_index_cpp::get_package_share_path(package_name); | ||
| map_path_ = (pkgpath / occmap_path_file).string(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR remove deprecated
get_package_share_directory, replacing byget_package_share_pathBest